Skip to content

fix error on response with code 429 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix error on response with code 429 #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions lib/dropbox_api/endpoints/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,19 @@ def process_response(raw_response)
raw_response.env[:api_result]['error']
)
when 429
error = DropboxApi::Errors::TooManyRequestsError.build(
raw_response.env[:api_result]['error_summary'],
raw_response.env[:api_result]['error']['reason']
)
# now while uploading a file dropbox returns 429 error code with none application/json content-type
# so raw_response.env[:api_result] is nil
error = if raw_response.env[:api_result]
DropboxApi::Errors::TooManyRequestsError.build(
raw_response.env[:api_result]['error_summary'],
raw_response.env[:api_result]['error']['reason']
)
else
DropboxApi::Errors::TooManyRequestsError.build(
'Too many requests.',
{ '.tag' => 'too_many_write_operations' }
)
end

error.retry_after = raw_response.headers['retry-after'].to_i

Expand Down
5 changes: 2 additions & 3 deletions spec/fixtures/vcr_cassettes/upload/too_many_write_operations.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.