[JEWEL] IJPL-175720 Improve scrolling sync so it handles identical markdown blocks correctly #2990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVanGogen
force-pushed
the
alexvangogen/IJPL-175720
branch
from
e6c1938 to
a3a836e
Compare
rock3r
approved these changes
May 2, 2025
...orm/jewel/markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/WithChildrenMarkdown.kt
Outdated
Show resolved
Hide resolved
...arkdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/scrolling/ScrollingSynchronizer.kt
Outdated
Show resolved
Hide resolved
obask
approved these changes
May 6, 2025
...arkdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/scrolling/ScrollingSynchronizer.kt
Show resolved
Hide resolved
...arkdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/scrolling/ScrollingSynchronizer.kt
Show resolved
Hide resolved
…identical markdown blocks correctly Introduce `LocatableMarkdownBlock` that decorates the regular `MarkdownBlock` with the information about the source lines it spans over. If it so happens that two `MarkdownBlock`s are equal, their decorations are equal only if their source lines are somehow the same, which doesn't make any difference to the synchronizer.
intellij-monorepo-bot
force-pushed
the
alexvangogen/IJPL-175720
branch
from
a3a836e to
82869a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally did it. After somewhat intensive manual testing, I found that it only works well with Oleg's changes. It means there's a bug somewhere in my current spans update, but I decided not to look for it and just merge this part after the mentioned PR :)