Add IC for Compose Wasm #809
Conversation
|
We are not merging this Pull Request for two reasons:
UPD(17.07.2025) - only 1st left |
dkrasnoff
force-pushed
the
compose-deployment
branch
from
52e4b0a to
4e52b2e
Compare
| @@ -0,0 +1,10 @@ | |||
| import org.gradle.api.attributes.Attribute | |||
|
|
|||
| enum class CacheAttribute { | |||
There was a problem hiding this comment.
With @ilgonmic we've discussed left only FULL.
Thus, the whole attribute can be deleted.
| @@ -39,6 +40,7 @@ kotlin-compiler-ide = { group = "org.jetbrains.kotlin", name = "kotlin-compiler- | |||
| kotlin-idea = { group = "org.jetbrains.kotlin", name = "idea", version.ref = "kotlinIdeVersionWithSuffix" } | |||
| kotlin-core = { group = "org.jetbrains.kotlin", name = "core", version.ref = "kotlinIdeVersionWithSuffix" } | |||
| kotlinx-coroutines-core-jvm = { group = "org.jetbrains.kotlinx", name = "kotlinx-coroutines-core-jvm", version.ref = "kotlinx-coroutines" } | |||
| kotlinx-coroutines-core-compose-wasm = { group = "org.jetbrains.kotlinx", name = "kotlinx-coroutines-core-wasm-js", version.ref = "kotlinx-coroutines-compose-wasm" } | |||
There was a problem hiding this comment.
Can it be just a kotlinx-coroutines-core dependency?
| .map { it.file("stdlib_master.wasm") } | ||
|
|
||
| rootProject.plugins.withType<org.jetbrains.kotlin.gradle.targets.js.binaryen.BinaryenRootPlugin> { | ||
| rootProject.the<BinaryenRootEnvSpec>().version = "122" |
There was a problem hiding this comment.
Why do we need such hardcoding?
| @@ -0,0 +1,97 @@ | |||
| @file:OptIn(ExperimentalWasmDsl::class) | |||
There was a problem hiding this comment.
@ilgonmic could you also add a Readme file to this new module?
| @@ -0,0 +1,155 @@ | |||
| import org.gradle.kotlin.dsl.support.serviceOf | |||
There was a problem hiding this comment.
@ilgonmic could you also add a Readme file to this new module?
| compilerOptions.freeCompilerArgs.add("-Xwasm-multimodule-mode=master") | ||
| } | ||
|
|
||
| (binary as WasmBinary).optimizeTask.configure { |
There was a problem hiding this comment.
@ilgonmic when should it work?
gradle/libs.versions.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [versions] | |||
| kotlin = "2.1.0" | |||
| kotlin = "2.2.0-dev-8507" | |||
There was a problem hiding this comment.
(Note for me, just not to forget) We can not change this version, because there are no changes in master branch
Copy of #775, created by @ilgonmic.