Custom types for wload to be used with produce_or_load #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump @jonas-schulze (I'm waiting on you here, I haven't done a review yet because you haven't labelled it as ready yet) |
|
Hi @Datseris, sorry for the delay. I don't know whether I'll be able to work on this within the next 4 weeks or so; I am trying to push my master thesis over the finish line. Is this blocking in any way? Maybe I can free up some time. |
|
No stress, nothing is blocking here. Was just checking if you forgot. Feel free to resume at any point you want. Once you have this ready, simply tag me here and ask for a review! |
|
bump here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #303#issuecomment-966395495.
This is very much work-in-progress. I just opened the PR so that I won't forget to work on it.
I've had a version that additionally checks wether the user has defined a custom saving method using
isempty(methodswith(returntype, _wsave))but didn't specifyreturntypeto dispatch forwload. Though, this is clearly heading towards the "magic" territory from a user's perspective. Is this desirable?Given that users might have defined methods for
FileIO.load, which does no longer receive all the arguments passed towsave, how breaking is this?Also, I didn't test this thoroughly, so even when it's finished, it maybe should simmer a bit before merging.