Skip to content

isapprox should work for comparing open and closed intervals #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

isapprox should work for comparing open and closed intervals #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acd00dd
isapprox should work for different intervals
dlfivefifty Dec 2, 2022
9951dde
v0.7.5
dlfivefifty Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "IntervalSets"
uuid = "8197267c-284f-5f27-9208-e0e47529a953"
version = "0.7.4"
version = "0.7.5"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
1 change: 0 additions & 1 deletion src/IntervalSets.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ isequal(A::TypedEndpointsInterval, B::TypedEndpointsInterval) = isempty(A) & ise
==(A::TypedEndpointsInterval, B::TypedEndpointsInterval) = isempty(A) && isempty(B)

function isapprox(A::AbstractInterval, B::AbstractInterval; atol=0, rtol=Base.rtoldefault(eltype(A), eltype(B), atol), kwargs...)
closedendpoints(A) != closedendpoints(B) && error("Comparing intervals with different closedness is not defined")
isempty(A) != isempty(B) && return false
isempty(A) && isempty(B) && return true
maxabs = max(maximum(abs, endpoints(A)), maximum(abs, endpoints(B)))
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ struct IncompleteInterval <: AbstractInterval{Int} end
@test 0..1 ≈ eps()..1
@test 100.0..100.0 ≉ nextfloat(100.0)..100.0
@test 3..1 ≈ 5..1
@test_throws Exception OpenInterval(0, 1) ≈ ClosedInterval(0, 1)
@test OpenInterval(0, 1) ≈ ClosedInterval(0, 1)
end

@testset "Convert" begin
Expand Down