Improve performance of fastica #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR takes produces the following timings for my `(2, 485156)` testinput ``` 565.305 ms (344 allocations: 37.05 MiB) # baseline 300.948 ms (211 allocations: 37.04 MiB) # inbounds 259.164 ms (192 allocations: 37.03 MiB) # @simd ```
baggepinnen
changed the title
Author
|
I noticed that my benchmarks were misleading due to the stochastic initialization of # do_whiten = true
334.604 ms (226 allocations: 22.23 MiB) # Baseline
325.827 ms (226 allocations: 22.23 MiB) # inbounds
# do_whiten = false
33.877 ms (44 allocations: 14.81 MiB) # baseline
32.711 ms (44 allocations: 14.81 MiB) # inbounds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR produces the following timings for my
(2, 485156)testinput