fix #905: use the correct mad() normalization #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
the
breaking
devmotion
reviewed
Apr 29, 2025
nalimilan
reviewed
Aug 1, 2025
| @@ -1,7 +1,7 @@ | |||
| name = "StatsBase" | |||
| uuid = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91" | |||
| authors = ["JuliaStats"] | |||
| version = "0.34.4" | |||
| version = "0.35.0" | |||
There was a problem hiding this comment.
We should really go to 1.0 next time we make a breaking release.
Suggested change
| version = "0.35.0" | |
| version = "1.0" |
It would be good to check whether we want to make other breaking changes though (I don't have ideas off the top of my head).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
mad()actually follow the definition of median absolute deviation as it is generally defined (eg https://en.wikipedia.org/wiki/Median_absolute_deviation, scipy, matlab, mathematica, ...).Obviously breaking. Are there any other breaking fixes that could go into the next StatsBase version?
See #905, #97, #347 for more context.