Fix method ambiguity for adjoint multiplication with Symbolics.Arr #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue #575 by adding a specific method for Adjoint{T, <:AbstractVector} multiplication with Symbolics.Arr{<:Any, 2}. This prevents the ambiguity between Base's adjoint multiplication method and Symbolics' matrix multiplication. The fix adds: - Specific @wrapped method for adjoint-matrix multiplication in src/array-lib.jl - Test case to verify the fix works and prevent regression 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjoint{T, <:AbstractVector}withSymbolics.Arr{<:Any, 2}(issue Ambiguous method on array adjoint of Num #575)Details
The issue occurred when trying to compute expressions like
d' * Ewheredis a symbolic vector andEis a symbolic matrix. This caused a method ambiguity between:Base.*(x::Adjoint{T, <:AbstractVector} where T, A::AbstractMatrix)Symbolics.*(A::AbstractMatrix, B::Symbolics.Arr{<:Any, 2})The fix adds a specific method
@wrapped (*)(x::Adjoint{T, <:AbstractVector} where {T}, A::Symbolics.Arr{<:Any, 2}) = _matmul(x, A) falsethat takes precedence and resolves the ambiguity.Test plan
Symbolics.Arr)Closes #575
🤖 Generated with Claude Code