Android ci #100
Draft
Android ci #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lievenhey
force-pushed
the
android-ci
branch
4 times, most recently
from
276329d to
2aa3bee
Compare
MiKom
reviewed
Nov 6, 2025
.github/workflows/build.yml
Outdated
Comment on lines
38
to
41
| mkdir build | ||
| cd build | ||
| cmake -DANDROID=ON -DKDUTILS_USE_EXTERNAL_DEPENDENCIES=ON .. | ||
| make -j `nproc` |
Member
There was a problem hiding this comment.
To simplify this a bit I'd do the following:
- Set CMAKE_GENERATOR env variable to "Ninja"
- do configure with `cmake -S . -B build [MORE_OPTIONS]
- build with
cmake --build build
MiKom
reviewed
Nov 6, 2025
| steps: | ||
| - name: Install dependencies | ||
| run: | | ||
| export CMAKE_TOOLCHAIN_FILE=/opt/android-sdk-linux/ndk/28.0.13004108/build/cmake/android.toolchain.cmake |
Member
There was a problem hiding this comment.
CMAKE_TOOLCHAIN_FILE and CMAKE_GENERATOR can be set once on the job level:
jobs:
build-android:
#...
env:
CMAKE_TOOLCHAIN_FILE: /opt/android-sdk-linux/ndk/28.0.13004108/build/cmake/android.toolchain.cmake
CMAKE_GENERATOR: NinjaSo you won't need to repeat them in each step
Member
There was a problem hiding this comment.
Not sure about $PATH it has self-reference and I'm not sure if:
env:
PATH: "/opt/android-sdk-linux/cmake/3.31.5/bin/:/opt/android-sdk-linux/ndk/28.0.13004108/prebuilt/linux-x86_64/bin/:${{env:PATH}}"
will work.
Another option is a separate early step:
steps:
- run: echo "/opt/android-sdk-linux/cmake/3.31.5/bin/:/opt/android-sdk-linux/ndk/28.0.13004108/prebuilt/linux-x86_64/bin/" >> $GITHUB_PATH
AFAIK, this adds to PATH for subsequent steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.