-
Notifications
You must be signed in to change notification settings - Fork 24
Add clang format from samples repo #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Format compute shader chapter as an example
Besides lots of other settings I'm using with the Vulkan-Hpp project, something like Just for reference, I've attached the clang-format from Vulkan-Hpp as a text file: clang-format.txt |
As agreed on the last call: I'll apply the clang format to all files and update this PR. |
No idea why the Android build fails. |
clang_format has sorted the includes. Now, |
Oh, that was prob. stupid. Will redo this PR without reordering the includes :/ |
No, that was not stupid. It's vulkan, that is stupid. Or maybe just |
That would be the better option. Didn't realize that the tutorial did explicitly include the core/platform specific headers. That indeed does not make much sense and should be changed indeed. Also feels odd that every chapter explicitly includes "vk_platform.h". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like merge conflicts. Could you address?
As noted in #126 code style is all over the place, making things hard to read.
We should start using a clang format file like we did in the samples to make sure code style follows a fixed set of guidelines.
This PR is there to discuss that. It adds the clang format file from the samples and applies that to one chapter.
We prob. still would have to do at least some manual fixups, as even clang format can't get everything into a good-to-read shape. But it should do hopefully around 90% of the job.
While modern C++ is generally hard on the eyes, this makes it at least somewhat easier to read and (more importantly) more consistent.