Skip to content

Fix the multiple socket connection issue when opening the widget immediately #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Fix the multiple socket connection issue when opening the widget immediately #1388

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f215f60
Fix the multiple socket connection issue when opening the widget imme…
panwaranuj01 Sep 18, 2025
8eba26b
Merge branch 'development' into multi-socket-issue
panwaranuj01 Oct 6, 2025
30d5692
added the test cases
panwaranuj01 Oct 6, 2025
d6a066a
revert the logic
panwaranuj01 Oct 6, 2025
fc2ce6d
remove unwanted timeout
panwaranuj01 Oct 7, 2025
e431dee
added the logs
panwaranuj01 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 56 additions & 6 deletions webplugin/js/app/mck-sidebox-1.0.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ var MCK_MAINTAIN_ACTIVE_CONVERSATION_STATE;
var CURRENT_GROUP_DATA = {};
var MCK_CHAT_POPUP_TEMPLATE_TIMER;
var IS_SOCKET_CONNECTED = false;
var IS_SOCKET_INITIALIZING = false;
var MCK_BOT_MESSAGE_QUEUE = [];
var WAITING_QUEUE = [];
var AVAILABLE_VOICES_FOR_TTS = new Array();
Expand Down Expand Up @@ -619,6 +620,7 @@ const firstVisibleMsg = {
) {
window.Applozic.ALSocket.disconnect();
window.Applozic.SOCKET_DISCONNECT_PROCEDURE.DISCONNECTED = true;
IS_SOCKET_INITIALIZING = false;
IS_SOCKET_CONNECTED = false;
console.debug('disconnected');
}
Expand Down Expand Up @@ -699,15 +701,23 @@ const firstVisibleMsg = {
kommunicate.reloadWidget();
return;
}
IS_SOCKET_INITIALIZING = false;
IS_SOCKET_CONNECTED = false;
if (navigator.onLine) {
window.Applozic.ALSocket.reconnect();
try {
IS_SOCKET_INITIALIZING = true;
window.Applozic.ALSocket.reconnect();
} catch (error) {
IS_SOCKET_INITIALIZING = false;
throw error;
}
}
SOCKET_RECONNECT_FAIL_COUNT++;
SOCKET_RECONNECT_FAIL_COUNT > 2 &&
kommunicateCommons.show('#km-socket-disconnect-msg');
},
onConnect: function (resp) {
IS_SOCKET_INITIALIZING = false;
IS_SOCKET_CONNECTED = true;
console.debug('connected..');
kommunicateCommons.hide('#km-local-file-system-warning');
Expand Down Expand Up @@ -1206,6 +1216,7 @@ const firstVisibleMsg = {
if (typeof window.Applozic.ALSocket !== 'undefined') {
kmLocalStorage.removeItemFromLocalStorage('feedbackGroups');
window.Applozic.ALSocket.disconnect();
IS_SOCKET_INITIALIZING = false;
appOptionSession.deleteSessionData();
window.Applozic.ALApiService.setAjaxHeaders('', '', '', '', '');
// Below function will clearMckMessageArray, clearAppHeaders, clearMckContactNameArray, removeEncryptionKey
Expand Down Expand Up @@ -1834,9 +1845,28 @@ const firstVisibleMsg = {
};

_this.initializeSocketConnection = function (isReInit) {
isReInit
? window.Applozic.ALSocket.reconnect()
: window.Applozic.ALSocket.init(MCK_APP_ID, INIT_APP_DATA, EVENTS);
if (IS_SOCKET_CONNECTED && !isReInit) {
return;
}

if (IS_SOCKET_INITIALIZING) {
console.debug('Socket initialization already in progress.');
return;
}

IS_SOCKET_INITIALIZING = true;

try {
if (isReInit) {
window.Applozic.ALSocket.reconnect();
} else {
window.Applozic.ALSocket.init(MCK_APP_ID, INIT_APP_DATA, EVENTS);
}
} catch (error) {
IS_SOCKET_INITIALIZING = false;
throw error;
}

// Disconnect open sockets if user has no conversations.
CONNECT_SOCKET_ON_WIDGET_CLICK &&
!MCK_TRIGGER_MSG_NOTIFICATION_TIMEOUT &&
Expand Down Expand Up @@ -2323,8 +2353,19 @@ const firstVisibleMsg = {
return;
}

if (IS_SOCKET_INITIALIZING) {
console.log('Socket initialization in progress. Skipping retry.');
return;
}

console.log(`Reconnecting socket... attempt ${reconnectAttempts + 1}`);
window.Applozic.ALSocket.reconnect();
try {
IS_SOCKET_INITIALIZING = true;
window.Applozic.ALSocket.reconnect();
} catch (error) {
IS_SOCKET_INITIALIZING = false;
throw error;
}

reconnectAttempts++;
if (reconnectAttempts >= maxAttempts) {
Expand Down Expand Up @@ -13548,7 +13589,16 @@ const firstVisibleMsg = {
}
}
if (!window.Applozic.ALSocket.stompClient.connected) {
window.Applozic.ALSocket.reconnect();
if (IS_SOCKET_INITIALIZING) {
return;
}
try {
IS_SOCKET_INITIALIZING = true;
window.Applozic.ALSocket.reconnect();
} catch (error) {
IS_SOCKET_INITIALIZING = false;
throw error;
}
}
};
_this.onTypingStatus = function (resp) {
Expand Down