helper functions: improve append_hostname() and sort_nodes()
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The function descriptions for append_hostname() and sort_nodes() could use some better descriptions. sort_nodes() as a whole could probably use some improvement via condensing it down. Edit the descriptions for both helper functions and remove the extra whitespace between the function description and the start of the function definition. In sort_nodes(): - simplify the string processing by checking "nodelist" directly instead of assigning it to another variable. - add an extract_key() function to extract the prefix, numeric part, and suffix using regex and return a tuple of it. - use the returned tuple from extract_key() to sort the original nodelist by prefix, numeric part, and suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The function descriptions for
append_hostname()andsort_nodes()could use some better descriptions.sort_nodes()as a whole could probably use some improvement via condensing it down.This PR edits the descriptions for both helper functions and remove the extra whitespace between the function description and the start of the function definition.
Specifically, in
sort_nodes():instead of assigning it to another variable.
and suffix using regex and return a tuple of it.
nodelist by prefix, numeric part, and suffix.