Showing an error message on invalid URLs #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shraiysh
changed the title
shraiysh
commented
Sep 2, 2020
| }, function () { | ||
| if (chrome.runtime.lastError) { | ||
| switch (chrome.runtime.lastError.message) { | ||
| case "Cannot access a chrome:// URL": |
There was a problem hiding this comment.
I could not find error code in the chrome.runtime.lastError. Let me know if there is a better way to do this.
There was a problem hiding this comment.
This looks fine. However, I don't see the need for both an if and a switch here. Maybe you can do some refactoring?
AdaephonBen
reviewed
Sep 25, 2020
| @@ -58,7 +58,11 @@ | |||
| </head> | |||
| <body> | |||
| <div class="heading"><p>aims helper<p></div> | |||
| <p class="status" style="display: none">You are not on the AIMS Page. </p> <!-- Replace with JS checker later. --> | |||
| <p class="status" id="error-message" style="display: none;">You are probably not on the appropriate AIMS page. Goto <a | |||
There was a problem hiding this comment.
Remove "probably". Add "please" before Goto.
AdaephonBen
reviewed
Sep 25, 2020
| @@ -1,4 +1,9 @@ | |||
| function activate() { | |||
|
|
|||
| if (!(document.location.href === "https://aims.iith.ac.in/aims/courseReg/studentRegForm/44")) { | |||
There was a problem hiding this comment.
This URL may very well change, so use a constant variable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5