-
Notifications
You must be signed in to change notification settings - Fork 4
fix CI install script #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vu3rdd
wants to merge
5
commits into
main
Choose a base branch
from
38.fix-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2f9e240
apt: do not ask for permission before installing a program
vu3rdd a7e4085
what is this cert failure stuff?
vu3rdd e444761
pip executable is called pip3?
vu3rdd ee3f97c
upgrade to newer cabal and run cabal configure
vu3rdd f580d59
cabal update before cabal install
vu3rdd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,27 +8,26 @@ jobs: | |
name: Install Dependencies | ||
command: | | ||
apt-get update | ||
apt-get install cabal-install | ||
apt-get install -y cabal-install | ||
|
||
- checkout | ||
|
||
- run: | ||
name: workaround for certificate failure | ||
command: | | ||
mv /etc/apt/sources.list.d/nodesource.list /etc/apt/sources.list.d/nodesource.list.disabled | ||
apt-get update | ||
apt-get -y upgrade | ||
apt-get install -y ca-certificates libgnutls30 | ||
mv /etc/apt/sources.list.d/nodesource.list.disabled /etc/apt/sources.list.d/nodesource.list | ||
|
||
- run: | ||
name: Install pip | ||
command: apt-get install -y python3-pip | ||
|
||
- run: | ||
name: Install dependencies | ||
command: pip install --user -r requirements.txt | ||
command: pip3 install --user -r requirements.txt | ||
|
||
- run: | ||
name: upgrade Cabal | ||
command: | | ||
cabal update | ||
cabal install cabal-install | ||
Comment on lines
+24
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there a particular version we think we need (perhaps a version newer than what's in the Debian package db)? Can we request that specifically? Or even if we just want some newer version, it would be nice to ask for one specifically, if we can, to improve reproducibility. |
||
|
||
- run: | ||
name: Tests | ||
command: cabal test | ||
command: | | ||
cabal configure --enable-tests | ||
cabal test |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add an hkdf pin to
requirements.txt
as protection against a future breaking version of hkdf.