Skip to content

Updated smaller footer #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Updated smaller footer #138

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b59c59
updated smaller footer
Jan 28, 2021
1040048
update-small-footer
Feb 2, 2021
cfc5ed3
update static footer screen
Feb 4, 2021
2f6f360
Add-download-text-button and bug-ci-github
Feb 4, 2021
3fe6735
update bug ci and download text button
Feb 4, 2021
124a7f3
Merge pull request #2 from perdi8/Add-download-text-button
perdi8 Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions front/src/common-app/components/footer/footer.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ export const footerContainer = css`
display: flex;
flex-direction: column;
justify-content: space-between;
height: ${spacing(37.5)};
padding: ${spacing(2.5)} ${spacing(12.5)};
height: ${spacing(20.5)};
padding: ${spacing(2)} ${spacing(12.5)};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is not a good idea you use these properties in the container and each container element, don't necessary and are confusing. This is my propsed CSS for your analysis and study. :-)
`import { css } from 'emotion';
import { theme } from 'core/theme';

const { palette, spacing, breakpoints } = theme;
const color = palette.customPalette;

export const footerContainer = cssdisplay: flex; flex-direction: column; justify-content: space-between; background-color: ${color.secondary};;

// you have change the name in footer.component.tsx
export const logoContainer = cssdisplay: flex; justify-content: center; align-items: center;;

export const bottomContainer = cssdisplay: flex; justify-content: space-between; padding: ${spacing(3)}; border-top: 1px solid ${color.primary}; @media (max-width: ${breakpoints.values.md}px) { flex-direction: column; justify-content: center; align-items: center; };

export const lemoncodeIcon = cssmax-width: 100px; padding: ${spacing(3)} 0;;

export const iconContainer = cssdisplay: flex; justify-content: space-between; width: 50%; margin: 0; padding: 0 0 ${spacing(1)}; list-style: none; @media (min-width: ${breakpoints.values.sm}px) { width: 20%; } @media (min-width: ${breakpoints.values.lg}px) { width: 10%; };

export const icon = cssfont-size: 1.5rem; color: ${color.greyLight}; &:hover { cursor: pointer; color: ${color.primary}; };

export const githubIcon = cssheight: ${spacing(2.75)}; fill: ${color.greyLight}; &:hover { cursor: pointer; fill: ${color.primary}; };

export const copyright = csscolor: ${color.greyLight}; @media (max-width: ${breakpoints.values.xs}px) { margin-top: ${spacing(0.8)}; };
`

background-color: ${color.secondary};
@media (max-width: ${breakpoints.values.md}px) {
padding: ${spacing(2.5)} ${spacing(5)} ${spacing(3.75)} ${spacing(5)};
Expand Down Expand Up @@ -54,7 +54,8 @@ export const bottomContainer = css`
`;

export const lemoncodeIcon = css`
height: ${spacing(12.5)};
height: ${spacing(12)};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

padding-bottom: ${spacing(1)}
`;

export const iconContainer = css`
Expand Down
19 changes: 13 additions & 6 deletions front/static/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,8 @@ form textarea {
display: flex;
flex-direction: column;
justify-content: space-between;
height: 30rem;
padding: 2rem 10rem;
height: 16rem;
padding: 0rem 10rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

background-color: var(--color-dark);
}

Expand Down Expand Up @@ -604,8 +604,15 @@ form textarea {
}

.footer__logo {
height: 10rem;
width: 11.2rem;
height: 9rem;
width: 10.2rem;
}

@media only screen and (max-width: 728px) {
.footer__logo {
height: 9rem;
width: 8.5rem;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

}

.footer__list {
Expand Down Expand Up @@ -660,8 +667,8 @@ form textarea {
top: 0.8rem;
right: 1.6rem;
fill: var(--color-light);
height: 10rem;
width: 10rem;
height: 8rem;
width: 8rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

}

.footer__icon-list {
Expand Down