Skip to content

Fixed pool cleanup #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fixed pool cleanup #24

wants to merge 12 commits into from

Conversation

stop777
Copy link
Contributor

@stop777 stop777 commented Mar 19, 2013

There was an Exception when calling AsyncClient.get after AsyncClient.start finished first time

@stop777
Copy link
Contributor Author

stop777 commented Mar 20, 2013

Also commit 0bb00b1, fixes situation when server returns HTTP Status header twice. Example http://cox.com - returns ('HTTP/1.1', '301', 'Moved Permanently'), then ('HTTP/1.1', '200', 'OK'). This causes exception

File "human_curl/core.py", line 781, in _parse_headers_raw
    self._headers = CaseInsensitiveDict(last_header[1:])
  File "human_curl/utils.py", line 104, in __init__
    tmp_d = dict(*args, **kwargs)

@stop777
Copy link
Contributor Author

stop777 commented Mar 20, 2013

А чего c pool cleanup?

Может этот request зарубить?

вместо 0bb00b1, сделал другой фикс. В отдельном реквесте #25

stop777 added 5 commits March 20, 2013 19:42
@stop777
added try catch while parsing headers, to prevent exception on bogus …
d1d4ae1 
…responses. e.g.

see "Apache" header

$ curl -q -v http://khabarfarsi.com > /dev/null
* About to connect() to khabarfarsi.com port 80 (#0)
*   Trying 176.9.154.107...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* connected
* Connected to khabarfarsi.com (176.9.154.107) port 80 (#0)
> GET / HTTP/1.1
> User-Agent: curl/7.28.1
> Host: khabarfarsi.com
> Accept: */*
>
< HTTP/1.1 200 OK
< Apache
< Content-Type: text/html; charset=utf-8
< Vary: Accept-Encoding, Cookie
< Etag: "1363793834-0"
@stop777
Merge branch 'header_parsing'
e30a4bd
@stop777
fixed indent
bfcc9bd
@stop777
Merge branch 'header_parsing'
7186258
@stop777
Created workaround for reset curl handler
fac4879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stop777 @Lispython