Skip to content

Conversation

Hatsune-Cthulhu
Copy link

@Hatsune-Cthulhu Hatsune-Cthulhu commented Sep 20, 2025

Description

Change to conditions under which cuda is enabled. This change will list VGA devices (GPUs), select the first one, this is, to my knowledge, the primary GPU in multi-GPU systems, and checks if this GPU is nvidia before checking if cuda is installed. This should address scenarios such as mine in which an external package has installed cuda on an incompatible system.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2025

CLA assistant check
All committers have signed the CLA.

@Hatsune-Cthulhu Hatsune-Cthulhu changed the title Add additional nvidia gpu check before cuda check build: Add additional nvidia gpu check before cuda check Sep 20, 2025
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I think the pkgrel also needs to be updated in 2 places.

Also, if this will persist across stable releases, it will also need to be added to https://github.com/LizardByte/Sunshine

@Hatsune-Cthulhu
Copy link
Author

Thank you for the PR!

I think the pkgrel also needs to be updated in 2 places.

Also, if this will persist across stable releases, it will also need to be added to https://github.com/LizardByte/Sunshine

I'm not sure about where else it'll be needed, guess it depends where AUR pulls the file from.

@ReenigneArcher
Copy link
Member

Here's the other location:

Copy link

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReenigneArcher
Copy link
Member

I'm fixing to make a stable release of Sunshine. If you'd like this patch included in the next stable release, could you submit a PR upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants