-
-
Notifications
You must be signed in to change notification settings - Fork 5
build: Add additional nvidia gpu check before cuda check #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
I think the pkgrel
also needs to be updated in 2 places.
Also, if this will persist across stable releases, it will also need to be added to https://github.com/LizardByte/Sunshine
I'm not sure about where else it'll be needed, guess it depends where AUR pulls the file from. |
Here's the other location:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me, but it will also need the change in https://github.com/LizardByte/Sunshine/blob/5800653055641dbbc0cab8c7ee5811901c85e926/packaging/linux/Arch/PKGBUILD#L69
I'm fixing to make a stable release of Sunshine. If you'd like this patch included in the next stable release, could you submit a PR upstream? |
Description
Change to conditions under which cuda is enabled. This change will list VGA devices (GPUs), select the first one, this is, to my knowledge, the primary GPU in multi-GPU systems, and checks if this GPU is nvidia before checking if cuda is installed. This should address scenarios such as mine in which an external package has installed cuda on an incompatible system.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage