Client basic auth support #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UTH_USER_FILE ENV var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds client auth support via simple HTTP basic auth. The flow here is:
CLIENT_AUTH_USER_FILEENV var is set to the htpasswd file path in the containerCLIENT_AUTH_USER_FILEvariable enables the client_auth.conf file in the nginx config, which configures basic auth via ngx_http_auth_basic_module.To pull from the registry clients must now auth with
docker loginusing credentials from the htpasswd file. Unauthenticated clients will get a error.When
CLIENT_AUTH_USER_FILEis unset (the default) application behavior is unchanged.This feature is useful in environments where having an open proxy that can pull from ECR is undesirable for security reasons.