Skip to content

Conversation

@naviak
Copy link

@naviak naviak commented Feb 24, 2022

Usage of kwargs seems to be better than the current usage of args..

@Lyken17
Copy link
Owner

Lyken17 commented Mar 1, 2022

This will change the default behavior of thop. Could you list some examples that requires kwargs for the net input?

@naviak
Copy link
Author

naviak commented Mar 4, 2022

Hi, for example it could be much easier to use thop working with transformers. Here u may see the forward function of BART model.
So user may pass not all parameters, e.g. input_ids, attention_mask and past_key_values.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants