Skip to content

CompatHelper: bump compat for PointClouds to 0.4, (keep existing compat) #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 4, 2024

This pull request changes the compat entry for the PointClouds package from 0.3 to 0.3, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-09-04-00-55-23-880-01550710448 branch from 6c1a799 to b452297 Compare September 4, 2024 00:55
@asinghvi17 asinghvi17 closed this Sep 4, 2024
@asinghvi17 asinghvi17 reopened this Sep 4, 2024
@SimonDanisch
Copy link
Member

We can't merge this, it is breaking...
I guess the error doesn't propagate to fail the docs, since it happens in an async task

@lazarusA
Copy link
Collaborator

lazarusA commented Apr 21, 2025

@SimonDanisch is this still breaking? all tests were ok. I bumped this as well in my latest merge to main, but if it is, we could always go back I suppose.

Edit:
and the only point cloud plot was already a white canvas https://makieorg.github.io/Tyler.jl/dev/map-3d#pointclouds, as in the previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants