Enhance accordion command #9617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase... I merged two of your PRs and it looks to be conflicted now |
asirvadAbrahamVarghese
force-pushed
the
enhance-accordion-command
branch
from
b5cba64 to
ee44933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to include accordionSelect API wait from
cy.accordioncommand, which eliminates the need to handle this separately in every test.Common url pattern noticed across the app(this doesn’t cover every flow, but I think the rest should be similar):
Matching them with a wildcard pattern:
/\/[^\/]+\/accordion_select\?id=.*/@miq-bot assign @jrafanie
@miq-bot add-label cypress
@miq-bot add-label enhancement