Bump minimum Python to 3.11 and av to 14.0.1 #4385
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,7 +117,7 @@ exclude = [ | |||
|
|
|||
| [tool.pytest.ini_options] | |||
| markers = "slow: Mark the test as slow. Can be skipped with --skip_slow" | |||
| addopts = "--no-cov-on-fail --cov=manim --cov-report xml --cov-report term -n auto --dist=loadfile --durations=0" | |||
| addopts = "--no-cov-on-fail --cov=manim --cov-report xml --cov-report term -n 10 --dist=loadfile --durations=0" | |||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Natural Language :: English", | ||
| ] | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.11" |
There was a problem hiding this comment.
Note: we should probably also remember to do this for mypy and ruff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with https://scientific-python.org/specs/spec-0000/ (which we have at some point loosely discussed to follow), our minimum supported Python version could be bumped to 3.11.
This also bumps the minimum required version of av to at least 14.0.1, while our metadata tests only appear to be fixed and working with 15.0.0, their latest release as of right now.
The PR is a draft for now as some additional cleanup is required; e.g.,
importlib-metadatacan be removed, the dependecies can remove the distinctions for Python 3.10.TODOs
importlib-metadatatyping_extensions?