Add support for negative z-index in AnimationGroup #4389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
3 tasks
behackl
reviewed
Aug 11, 2025
| @@ -904,7 +931,7 @@ def get_moving_mobjects(self, *animations: Animation) -> list[Mobject]: | |||
| # as soon as there's one that needs updating of | |||
| # some kind per frame, return the list from that | |||
| # point forward. | |||
| animation_mobjects = [anim.mobject for anim in animations] | |||
| animation_mobjects = self.recursively_unpack_animation_groups(*animations) | |||
There was a problem hiding this comment.
If it works, I'd prefer a simpler solution not requiring a new method; something along the lines of the suggestion from my previous review:
Suggested change
| animation_mobjects = self.recursively_unpack_animation_groups(*animations) | |
| animation_mobjects = [] | |
| for anim in animations: | |
| animation_mobject.extend(anim.mob.get_family()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes an AnimationGroup behaviour with negative z_index Mobjects. More about this problem you can see in these issues:
#3334 and #3914
Motivation and Explanation: Why and how do your changes improve the library?
Mobjects with negative z_index have problems with playing in animations. This PR fixes it
Links to added or changed documentation pages
There are no changes to the documentation
Further Information and Comments
I had already opened a pull request, but I decided to close it due to many issues with the previous solution. I have taken all the shortcomings, now there are no performance or graphical test issues.
Reviewer Checklist