Skip to content

DialogHost API revamp #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 77 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
ede38d4
Cleanup of launchSettings and Cards Page in Demo
Oct 24, 2024
8c8644a
Revert "Cleanup of launchSettings and Cards Page in Demo"
Oct 24, 2024
550c20d
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Oct 29, 2024
649b234
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Nov 4, 2024
83ab505
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Nov 19, 2024
75b12a6
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Nov 29, 2024
ec4ab7e
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Dec 12, 2024
693f32e
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Dec 20, 2024
ffc320a
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Jan 2, 2025
d216821
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Jan 3, 2025
5ea61a4
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Jan 8, 2025
202c919
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Jan 27, 2025
1eb432e
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Jan 31, 2025
622c328
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Feb 12, 2025
737a145
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Feb 17, 2025
27bbd55
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Feb 28, 2025
0751054
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Mar 11, 2025
7d9cf1b
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Mar 12, 2025
129653d
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Mar 14, 2025
4858124
Merge branch 'master' of https://github.com/corvinsz/MaterialDesignIn…
Mar 31, 2025
8228167
-added "isFullscreenDialog" Parameter to all Dialog.Show methods
Mar 31, 2025
5e386eb
before showing the Dialog remove the Dialogs Margin and CornerRadius …
corvinsz Mar 31, 2025
4466075
added summary description for "isFullscreenDialog"
corvinsz Mar 31, 2025
34f7767
applied newer "syntactic sugar" features
corvinsz Mar 31, 2025
485a4ca
resize and reposition the PopupEx if the Window is resized or reposit…
Apr 1, 2025
7e8d9fc
added PART_CloseButton to the Template of the DialogHost
Apr 1, 2025
e5d37f3
-added DialogOptions class
Apr 1, 2025
f1d4c2a
-added demo page for DialogOptions
corvinsz Apr 1, 2025
d0b71cb
demo cleanup
corvinsz Apr 2, 2025
f36b86a
save size of Popup before setting it to fullscreen so the height and …
corvinsz Apr 2, 2025
e43653e
-removed unused variables and summaries
corvinsz Apr 2, 2025
5ff9626
added BlurBackground to the DialogOptions and showcase it the demo
corvinsz Apr 10, 2025
e98f550
Mark the old Show methods as obsolete
corvinsz Apr 10, 2025
2444022
fix to restore the BlurRadius correctly
corvinsz Apr 29, 2025
affc82a
-if no DialogOptions are supplied, fall back to Defaults
corvinsz Apr 29, 2025
1e856d0
Lift ContentControl from child of Ripple, to sibling of Ripple (#3843)
nicolaihenriksen May 9, 2025
1ab7331
use powershell script to convert old brush names to new ones (#3846)
corvinsz May 9, 2025
f5a504d
UpDownBase: Fix event subscription mismatch (#3844)
nicolaihenriksen May 9, 2025
3b30b20
Fix AutoSuggestBox not setting SelectedItem (#3847)
corvinsz May 9, 2025
35167df
added AP to control the cursor when hovering over a ListBoxItem and m…
corvinsz May 16, 2025
5f75c3b
Fix for 3851 - Dark mode not working anymore (#3852)
JorisCleVR May 30, 2025
c506371
Chip: Added TemplateBinding Padding (#3850)
JorisCleVR May 30, 2025
db64576
Set MaterialDesignPopupBox/PART_Toggle.VerticalAlignment to Stretch (…
greuelpirat May 30, 2025
e7bc4d3
Fix namespace for DesignInstances in MaterialDesignDemo.Shared.Domain…
greuelpirat May 30, 2025
c2c8793
Use CultureInfo.CurrentCulture for string conversions of Value (#3860)
nicolaihenriksen Jun 6, 2025
7ddc81b
#3853: RelativeSource FindAncestor binding errors (#3862)
JorisCleVR Jun 6, 2025
6cef2f5
Forward HintAssist.HintPaddingBrush into nested TextBox of UpDown (#3…
nicolaihenriksen Jun 6, 2025
0ed85d0
Modify DecimalUpDown basic test to ensure culture is respected in str…
nicolaihenriksen Jun 8, 2025
f0f5fdc
Fixed PopUpBox VerticalContentAlignment (#3864)
JorisCleVR Jun 8, 2025
442f311
Used x:Reference in Button and ProgressBar ControlTemplates (#3868)
JorisCleVR Jun 13, 2025
182b60a
Chip: Fixed without icon padding (#3869)
JorisCleVR Jun 13, 2025
556b412
ToggleButton uses EllipseClipConverter (#3867)
JorisCleVR Jun 13, 2025
cf1afbc
Remove .NET 6 as EOL (#3859)
L1nstead Jun 13, 2025
66b836b
TextBoxLineCountBehavior: Fixed NullReferenceException when used with…
JorisCleVR Jun 13, 2025
4733a54
Evaluate TextBox.LineCount only once in UpdateAttachedProperties (#3874)
greuelpirat Jun 18, 2025
122a534
added ToolTip demo page with a RichToolTip example. Applied new synta…
corvinsz Jun 19, 2025
bbdee06
fix when the TreeListView expands too much content, scrolling to the …
MohammadHadi2031 Jun 26, 2025
f31fe78
Updating tests to use TUnit and MTP (#3838)
Keboo Jun 27, 2025
b110061
Fix Enhance Mouseover Visuals for TabControl (#3803)
corvinsz Jun 27, 2025
fad77d5
Exposes BindableIsItemsHost attached property. (#3878)
Keboo Jun 27, 2025
22d4651
Revert "Cleanup of launchSettings and Cards Page in Demo"
Oct 24, 2024
8d41d5e
-added "isFullscreenDialog" Parameter to all Dialog.Show methods
Mar 31, 2025
1bd4fe9
before showing the Dialog remove the Dialogs Margin and CornerRadius …
corvinsz Mar 31, 2025
169d77c
added summary description for "isFullscreenDialog"
corvinsz Mar 31, 2025
3ad8685
applied newer "syntactic sugar" features
corvinsz Mar 31, 2025
39f3dee
resize and reposition the PopupEx if the Window is resized or reposit…
Apr 1, 2025
e2a934b
added PART_CloseButton to the Template of the DialogHost
Apr 1, 2025
b4ea591
-added DialogOptions class
Apr 1, 2025
e24c4b5
-added demo page for DialogOptions
corvinsz Apr 1, 2025
a8ca75d
demo cleanup
corvinsz Apr 2, 2025
613bbd0
save size of Popup before setting it to fullscreen so the height and …
corvinsz Apr 2, 2025
b98c47d
-removed unused variables and summaries
corvinsz Apr 2, 2025
570e85f
added BlurBackground to the DialogOptions and showcase it the demo
corvinsz Apr 10, 2025
a3ebda1
Mark the old Show methods as obsolete
corvinsz Apr 10, 2025
9b5eb8a
fix to restore the BlurRadius correctly
corvinsz Apr 29, 2025
4b2a1b0
-if no DialogOptions are supplied, fall back to Defaults
corvinsz Apr 29, 2025
4104cc2
Merge branch 'feat/FullscreenDialog' of https://github.com/corvinsz/M…
corvinsz Jul 1, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:
uses: actions/setup-dotnet@v4
with:
dotnet-version: |
6.x
8.x
9.x

- name: Restore dependencies
run: dotnet restore ${{ env.solution }}
Expand All @@ -54,7 +54,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: Screenshots-${{ github.run_number }}
path: ${{ github.workspace }}tests\MaterialDesignThemes.UITests\bin\${{ inputs.build-configuration }}\net8.0-windows7\Screenshots
path: ${{ github.workspace }}\tests\MaterialDesignThemes.UITests\bin\${{ inputs.build-configuration }}\net9.0-windows\Screenshots
if-no-files-found: ignore

- name: Build NuGets
Expand Down
13 changes: 6 additions & 7 deletions Directory.packages.props
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<Project>
<ItemGroup>
<PackageVersion Include="BluwolfIcons" Version="1.0.1" />
<PackageVersion Include="CommunityToolkit.Mvvm" Version="8.2.2" />
<PackageVersion Include="CommunityToolkit.Mvvm" Version="8.4.0" />
<PackageVersion Include="Dragablz" Version="0.0.3.234" />
<PackageVersion Include="GitHubActionsTestLogger" Version="2.3.3" />
<PackageVersion Include="GitHubActionsTestLogger" Version="2.4.1" />
<PackageVersion Include="Humanizer" Version="2.14.1" />
<PackageVersion Include="MahApps.Metro" Version="2.4.10" />
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" />
Expand All @@ -14,7 +14,7 @@
<PackageVersion Include="Microsoft.Composition" Version="1.0.31" />
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
<PackageVersion Include="Microsoft.NETCore.Platforms" Version="7.0.4" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<PackageVersion Include="Microsoft.Toolkit.MVVM" Version="7.1.2" />
<PackageVersion Include="Microsoft.Xaml.Behaviors.Wpf" Version="1.1.77" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
Expand All @@ -24,11 +24,10 @@
<PackageVersion Include="ShowMeTheXAML.MSBuild" Version="2.0.0" />
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
<PackageVersion Include="System.Private.Uri" Version="4.3.2" />
<PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" />
<PackageVersion Include="TUnit" Version="0.25.21" />
<PackageVersion Include="VirtualizingWrapPanel" Version="1.5.8" />
<PackageVersion Include="XAMLTest" Version="1.2.2" />
<PackageVersion Include="xunit" Version="2.6.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.5.4" />
<PackageVersion Include="Xunit.StaFact" Version="1.1.11" />
<PackageVersion Include="XAMLTest" Version="1.3.0-ci616" />
</ItemGroup>
</Project>
3 changes: 0 additions & 3 deletions MaterialDesignToolkit.Full.sln
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
Directory.packages.props = Directory.packages.props
.config\dotnet-tools.json = .config\dotnet-tools.json
global.json = global.json
MaterialDesignColors.nuspec = MaterialDesignColors.nuspec
MaterialDesignThemes.MahApps.nuspec = MaterialDesignThemes.MahApps.nuspec
MaterialDesignThemes.nuspec = MaterialDesignThemes.nuspec
build\MigrateBrushes.ps1 = build\MigrateBrushes.ps1
nuget.config = nuget.config
README.md = README.md
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.100",
"version": "9.0.300",
"rollForward": "latestMinor"
}
}
2 changes: 1 addition & 1 deletion src/MahMaterialDragablzMashUp/MahAppsDragablzDemo.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>WinExe</OutputType>
<TargetFrameworks>net472;net6.0-windows;net8.0-windows</TargetFrameworks>
<TargetFrameworks>net472;net8.0-windows</TargetFrameworks>
<UseWPF>true</UseWPF>
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
Expand Down
2 changes: 1 addition & 1 deletion src/MainDemo.Wpf/App.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
If you would prefer to use your own colors, there is an option for that as well:
PrimaryColor and SecondaryColor also support the constant string "Inherit" to specify the color should use the system theme accent color
-->
<materialDesign:CustomColorTheme BaseTheme="Light" PrimaryColor="Aqua" SecondaryColor="#FF006400" />
<!--<materialDesign:CustomColorTheme BaseTheme="Light" PrimaryColor="Aqua" SecondaryColor="#FF006400" />-->

<!-- You can also use the built-in theme dictionaries: -->
<!--
Expand Down
4 changes: 2 additions & 2 deletions src/MainDemo.Wpf/Buttons.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:domain="clr-namespace:MaterialDesignDemo.Domain"
xmlns:sharedDomain="clr-namespace:MaterialDesignDemo.Shared.Domain;assembly=MaterialDesignDemo.Shared"
xmlns:materialDesign="http://materialdesigninxaml.net/winfx/xaml/themes"
xmlns:materialDesignConverters="clr-namespace:MaterialDesignThemes.Wpf.Converters;assembly=MaterialDesignThemes.Wpf"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:smtx="clr-namespace:ShowMeTheXAML;assembly=ShowMeTheXAML"
xmlns:system="clr-namespace:System;assembly=mscorlib"
d:DataContext="{d:DesignInstance domain:ButtonsViewModel}"
d:DataContext="{d:DesignInstance sharedDomain:ButtonsViewModel}"
d:DesignHeight="2000"
d:DesignWidth="800"
mc:Ignorable="d">
Expand Down
16 changes: 16 additions & 0 deletions src/MainDemo.Wpf/Cards.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,22 @@
<TextBlock Style="{StaticResource PageTitleTextBlock}" Text="Card" />

<WrapPanel>

<smtx:XamlDisplay Margin="0,0,8,8" UniqueKey="cards_11111">
<Grid Background="Blue">
<materialDesign:Card materialDesign:ElevationAssist.Elevation="Dp24" Margin="25" UniformCornerRadius="100" Padding="0" BorderThickness="0" >
<Grid Background="Black" Height="300" Width="300" Margin="0">
<TextBlock HorizontalAlignment="Center"
VerticalAlignment="Center"
Foreground="White"
Text="The quick brown fox jumps over the lazy dog"
Margin="20"
TextWrapping="Wrap"/>
</Grid>
</materialDesign:Card>
</Grid>
</smtx:XamlDisplay>

<smtx:XamlDisplay Margin="0,0,8,8" UniqueKey="cards_1">
<materialDesign:Card Width="200">
<Grid>
Expand Down
4 changes: 2 additions & 2 deletions src/MainDemo.Wpf/ColorTool.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:converters="clr-namespace:MaterialDesignDemo.Shared.Converters;assembly=MaterialDesignDemo.Shared"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:domain="clr-namespace:MaterialDesignDemo.Domain"
xmlns:sharedDomain="clr-namespace:MaterialDesignDemo.Shared.Domain;assembly=MaterialDesignDemo.Shared"
xmlns:local="clr-namespace:MaterialDesignDemo"
xmlns:materialDesign="http://materialdesigninxaml.net/winfx/xaml/themes"
xmlns:materialDesignColors="clr-namespace:MaterialDesignColors;assembly=MaterialDesignColors"
xmlns:materialDesignConverters="clr-namespace:MaterialDesignThemes.Wpf.Converters;assembly=MaterialDesignThemes.Wpf"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
d:DataContext="{d:DesignInstance Type=domain:ColorToolViewModel}"
d:DataContext="{d:DesignInstance Type=sharedDomain:ColorToolViewModel}"
d:DesignHeight="600"
d:DesignWidth="600"
mc:Ignorable="d">
Expand Down
4 changes: 2 additions & 2 deletions src/MainDemo.Wpf/ComboBoxes.xaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<UserControl x:Class="MaterialDesignDemo.ComboBoxes"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:colorsDomain="clr-namespace:MaterialDesignDemo.Domain"
xmlns:sharedDomain="clr-namespace:MaterialDesignDemo.Shared.Domain;assembly=MaterialDesignDemo.Shared"
xmlns:converters="clr-namespace:MaterialDesignDemo.Shared.Converters;assembly=MaterialDesignDemo.Shared"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:demoAppDomain="clr-namespace:MaterialDesignDemo.Domain"
xmlns:materialDesign="http://materialdesigninxaml.net/winfx/xaml/themes"
xmlns:materialDesignDemo="clr-namespace:MaterialDesignDemo"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:smtx="clr-namespace:ShowMeTheXAML;assembly=ShowMeTheXAML"
d:DataContext="{d:DesignInstance colorsDomain:ComboBoxesViewModel,
d:DataContext="{d:DesignInstance sharedDomain:ComboBoxesViewModel,
IsDesignTimeCreatable=False}"
d:DesignHeight="1080"
d:DesignWidth="1920"
Expand Down
Loading
Loading