Skip to content

orchestratord test: Fix upgrade tests and reenable authenticator kinds #34130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

orchestratord test: Fix upgrade tests and reenable authenticator kinds #34130

merged 1 commit into from
Nov 18, 2025
+47 −32

Conversation

@def-
Copy link
Contributor

@def- def- commented Nov 14, 2025 •
edited
Loading

Fixes: https://github.com/MaterializeInc/database-issues/issues/9899

Test run: https://buildkite.com/materialize/nightly/builds/14082

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-orchestratord-upgrade2 branch 2 times, most recently from e400efe to d00bbf9 Compare November 14, 2025 13:18
@def- def- changed the title orchestratord test: Fix upgrade tests orchestratord test: Fix upgrade tests and reenable authenticator kinds Nov 14, 2025
@def- def- marked this pull request as ready for review November 14, 2025 14:12
@def- def- requested review from a team as code owners November 14, 2025 14:12
@def-
Copy link
Contributor Author

def- commented Nov 14, 2025

Nightly is green, ready fore review! https://buildkite.com/materialize/nightly/builds/14082#_

alex-hunt-materialize
alex-hunt-materialize reviewed Nov 18, 2025
View reviewed changes
@def- def- force-pushed the pr-orchestratord-upgrade2 branch from d00bbf9 to b9d6fba Compare November 18, 2025 11:17
@def- def- merged commit 9d1d839 into MaterializeInc:main Nov 18, 2025
5 checks passed
@def- def- deleted the pr-orchestratord-upgrade2 branch November 18, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-hunt-materialize alex-hunt-materialize alex-hunt-materialize approved these changes

@bobbyiliev bobbyiliev Awaiting requested review from bobbyiliev

@doy-materialize doy-materialize Awaiting requested review from doy-materialize

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@def- @alex-hunt-materialize