Remove component uses of MBEDTLS_ECDSA_DETERMINISTIC
#10367
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all references to MBEDTLS_ECDSA_DETERMINISTIC from components-configuration-crypto.sh. Replace them with PSA_WANT_ALG_DETERMINISTIC_ECDSA. This is safe because: * MBEDTLS_ECDSA_DETERMINISTIC is only ever unset in components in order to avoid errors from disabling its dependency MBEDTLS_HMAC_DRBG_C. * MBEDTLS_ECDSA_DETERMINISTIC is only ever defined in config_adjust_legacy_from_psa.h, and only if PSA_WANT_ALG_DETERMINISTIC_ECDSA is defined. Therefore PSA_WANT_ALG_DETERMINISTIC_ECDSA's dependencies are a superset of MBEDTLS_ECDSA_DETERMINISTIC's dependencies and must include MBEDTLS_HMAC_DRBG_C, so disabling PSA_WANT_ALG_DETERMINISTIC_ECDSA is a sufficient substitute for disabling MBEDTLS_ECDSA_DETERMINISTIC. Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
added
needs-ci
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
davidhorstmann-arm
moved this from In Development
to In Review
in Roadmap pull requests (new board)
davidhorstmann-arm
changed the title
MBEDTLS_ECDSA_DETERMINISTIC
ronald-cron-arm
requested changes
Aug 25, 2025
| @@ -210,7 +210,7 @@ component_test_no_hmac_drbg_use_psa () { | |||
| msg "build: Full minus HMAC_DRBG, PSA crypto in TLS" | |||
| scripts/config.py full | |||
| scripts/config.py unset MBEDTLS_HMAC_DRBG_C | |||
| scripts/config.py unset MBEDTLS_ECDSA_DETERMINISTIC # requires HMAC_DRBG | |||
| scripts/config.py -c $CRYPTO_CONFIG_H unset PSA_WANT_ALG_DETERMINISTIC_ECDSA # requires HMAC_DRBG | |||
There was a problem hiding this comment.
Suggested change
| scripts/config.py -c $CRYPTO_CONFIG_H unset PSA_WANT_ALG_DETERMINISTIC_ECDSA # requires HMAC_DRBG | |
| scripts/config.py unset PSA_WANT_ALG_DETERMINISTIC_ECDSA # requires HMAC_DRBG |
There was a problem hiding this comment.
"-c $CRYPTO_CONFIG_H was necessary at some point, but hasn't been for a while now. I had been planning to clean it up eventually. I know this isn’t the main focus of this PR, but would you mind cleaning it up across all the components-*.sh scripts?"
github-project-automation
bot
moved this from In Review
to In Development
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10328
Remove all references to
MBEDTLS_ECDSA_DETERMINISTICfromcomponents-configuration-crypto.sh. Replace them withPSA_WANT_ALG_DETERMINISTIC_ECDSA.This is safe because:
MBEDTLS_ECDSA_DETERMINISTICis only ever unset in components in order to avoid errors from disabling its dependencyMBEDTLS_HMAC_DRBG_C.MBEDTLS_ECDSA_DETERMINISTICis only ever defined inconfig_adjust_legacy_from_psa.h, and only ifPSA_WANT_ALG_DETERMINISTIC_ECDSAis defined.Therefore
PSA_WANT_ALG_DETERMINISTIC_ECDSA's dependencies are a superset ofMBEDTLS_ECDSA_DETERMINISTIC's dependencies and must includeMBEDTLS_HMAC_DRBG_C, so disablingPSA_WANT_ALG_DETERMINISTIC_ECDSAis a sufficient substitute for disablingMBEDTLS_ECDSA_DETERMINISTIC.PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.