Skip to content

Conversation

felixc-arm
Copy link
Contributor

@felixc-arm felixc-arm commented Aug 21, 2025

Resolves #10247, based on top of #10363

Dependency Chain:
[1/3] #10363
[2/3] Mbed-TLS/TF-PSA-Crypto#422
[3/3] THIS PR

Removes #define MBEDTLS_ERR_xxx... PSA_ERROR_...s lines as these error definitions are now in tf-psa-crypto/include/pas/crypto_unified_errors.h due to PR [2/3].

PR checklist

Previously these tests used values that will become PSA aliases,
and so the tests will fail once they're changed.

Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
@felixc-arm felixc-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Aug 21, 2025
@felixc-arm felixc-arm removed the needs-ci Needs to pass CI tests label Aug 21, 2025
Signed-off-by: Felix Conway <felix.conway@arm.com>
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in outline, the libtestdriver fix commit is out of date compared to #10363 and the TF-PSA-Crypto pointer update seems to point to an older version of Mbed-TLS/TF-PSA-Crypto#422.

Otherwise looks generally okay

@felixc-arm felixc-arm force-pushed the unify-error-codes branch 2 times, most recently from 1e69ced to b0a298d Compare August 28, 2025 15:20
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
…eader file

Signed-off-by: Felix Conway <felix.conway@arm.com>
Signed-off-by: Felix Conway <felix.conway@arm.com>
@mpg mpg self-assigned this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-preceding-pr Requires another PR to be merged first needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Development

Successfully merging this pull request may close these issues.

Unify error codes for generic conditions
3 participants