Skip to content

Add StartupViewModel unit tests #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2025
Merged

Add StartupViewModel unit tests #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions ...src/test/java/com/d4rk/androidtutorials/java/ui/screens/startup/StartupViewModelTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package com.d4rk.androidtutorials.java.ui.screens.startup;

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;

import android.app.Activity;

import androidx.arch.core.executor.testing.InstantTaskExecutorRule;

import com.d4rk.androidtutorials.java.data.repository.StartupRepository.OnFormError;
import com.d4rk.androidtutorials.java.domain.startup.LoadConsentFormUseCase;
import com.d4rk.androidtutorials.java.domain.startup.RequestConsentInfoUseCase;
import com.google.android.ump.ConsentRequestParameters;

import org.junit.Rule;
import org.junit.Test;

public class StartupViewModelTest {

@Rule
public InstantTaskExecutorRule instantTaskExecutorRule = new InstantTaskExecutorRule();

@Test
public void requestConsentInfoUpdateDelegatesToUseCase() {
RequestConsentInfoUseCase requestUseCase = mock(RequestConsentInfoUseCase.class);
LoadConsentFormUseCase loadUseCase = mock(LoadConsentFormUseCase.class);
StartupViewModel viewModel = new StartupViewModel(requestUseCase, loadUseCase);

Activity activity = mock(Activity.class);
ConsentRequestParameters params = mock(ConsentRequestParameters.class);
Runnable onSuccess = mock(Runnable.class);
OnFormError onError = mock(OnFormError.class);

viewModel.requestConsentInfoUpdate(activity, params, onSuccess, onError);

verify(requestUseCase).invoke(activity, params, onSuccess, onError);
Comment on lines +32 to +36
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Fix OnFormError type mismatch in StartupViewModel tests

The new tests pass com.d4rk.androidtutorials.java.data.repository.StartupRepository.OnFormError into StartupViewModel.requestConsentInfoUpdate, but the ViewModel’s method is typed to com.d4rk.androidtutorials.java.ui.screens.startup.repository.StartupRepository.OnFormError (a type that doesn’t exist). This causes the test suite to fail to compile before it can exercise the delegation logic. Align the test with the ViewModel’s API or, preferably, adjust the ViewModel to depend on the data-layer interface so both production and test code compile.

Useful? React with 👍 / 👎.

}

@Test
public void loadConsentFormDelegatesToUseCase() {
RequestConsentInfoUseCase requestUseCase = mock(RequestConsentInfoUseCase.class);
LoadConsentFormUseCase loadUseCase = mock(LoadConsentFormUseCase.class);
StartupViewModel viewModel = new StartupViewModel(requestUseCase, loadUseCase);

Activity activity = mock(Activity.class);
OnFormError onError = mock(OnFormError.class);

viewModel.loadConsentForm(activity, onError);

verify(loadUseCase).invoke(activity, onError);
}
}