Add tests for app update notifications #231
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| private final Context context; | ||
| private final IntSupplier sdkIntSupplier; | ||
| private final String updateChannelId = "update_channel"; | ||
| private final int updateNotificationId = 0; | ||
|
|
||
| public AppUpdateNotificationsManager(Context context) { | ||
| this(context, () -> Build.VERSION.SDK_INT); | ||
| } | ||
|
|
||
| AppUpdateNotificationsManager(Context context, IntSupplier sdkIntSupplier) { | ||
| this.context = context; | ||
| this.sdkIntSupplier = sdkIntSupplier; |
There was a problem hiding this comment.
[P1] Avoid API‑24 java.util.function dependency in manager constructor
The new sdkIntSupplier field introduces java.util.function.IntSupplier. That type only exists on Android API 24+ (or when core library desugaring is configured), yet the app’s minSdk is 23 and no desugaring dependency is declared in app/build.gradle. When AppUpdateNotificationsManager is loaded on API 23 devices (e.g., from MainActivity), the VM will fail with NoClassDefFoundError: java/util/function/IntSupplier, crashing update notification checks on those devices. Passing the SDK value as an int or using a project-defined interface avoids raising the effective minSdk.
Useful? React with 👍 / 👎.
1 participant
Summary
AppUpdateNotificationsManagerguards notification channel creation behind the runtime SDK levelAppUpdateManagerresults and verify Play Store intents and notification behaviorTesting
https://chatgpt.com/codex/tasks/task_e_68c97637f974832dbddeb70b7567debc