Skip to content

Support for mods with "Chance to cast ... when" like Decimate #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Support for mods with "Chance to cast ... when" like Decimate #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions spec/System/TestModParse_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,4 +191,12 @@ describe("TestModParse", function()

assert.are.equals(17, build.configTab.modList:Sum("BASE", {flags = ModFlag.Hit}, "ChanceToTriggerOnHit_Ailment_Bleed"))
end)

it("decimate cast chance", function()
build.configTab.input.customMods = "17% Chance to cast Decimate when you directly use a Fire Spell (4 second cooldown)"
build.configTab:BuildModList()
runCallback("OnFrame")

assert.are.equals(17, build.configTab.modList:Sum("BASE", {keywordFlags = KeywordFlag.Fire}, "ChanceToTriggerOnHit_GasparSetSwipe"))
end)
end)
2 changes: 1 addition & 1 deletion spec/TestBuilds/1.2/warpath_channel.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
["ColdTakenReflect"] = 1,
["ColdTotalHitPool"] = 3400,
["ColdTotalPool"] = 3400,
["ColdtakenFlat"] = 0,

Check warning on line 85 in spec/TestBuilds/1.2/warpath_channel.lua

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Coldtaken)
["CombinedAvg"] = 7846.0257,
["CombinedDPS"] = 7846.0257,
["ConfiguredDamageChance"] = 100,
Expand All @@ -106,7 +106,7 @@
["DoubleDamageEffect"] = 0,
["Duration"] = 0.21,
["DurationMod"] = 1,
["EHPsurvivalTime"] = 1.8168,

Check warning on line 109 in spec/TestBuilds/1.2/warpath_channel.lua

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Psurvival)
["ESCost"] = 0,
["ESHasCost"] = false,
["ESPerSecondCost"] = 0,
Expand Down Expand Up @@ -160,13 +160,13 @@
["FireTakenReflect"] = 1,
["FireTotalHitPool"] = 3400,
["FireTotalPool"] = 3400,
["FiretakenFlat"] = 0,

Check warning on line 163 in spec/TestBuilds/1.2/warpath_channel.lua

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Firetaken)
["FistOfWarAilmentEffect"] = 1,
["FistOfWarCooldown"] = 0,
["FistOfWarHitEffect"] = 1,
["FrostShieldDamageMitigation"] = 0,
["FrostShieldLife"] = 0,
["FullDPS"] = 8730.4421,
["FullDPS"] = 8795.7605,
["FullLifePercentage"] = 100,
["HitChance"] = 100,
["IgniteAvoidChance"] = 0,
Expand Down Expand Up @@ -235,7 +235,7 @@
["LightningTakenReflect"] = 1,
["LightningTotalHitPool"] = 3400,
["LightningTotalPool"] = 3400,
["LightningtakenFlat"] = 0,

Check warning on line 238 in spec/TestBuilds/1.2/warpath_channel.lua

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Lightningtaken)
["LowLifePercentage"] = 50,
["LowestOfArmourAndEvasion"] = 94,
["LowestOfMaximumLifeAndMaximumMana"] = 246,
Expand Down Expand Up @@ -324,7 +324,7 @@
["NecroticTakenReflect"] = 1,
["NecroticTotalHitPool"] = 3400,
["NecroticTotalPool"] = 3400,
["NecrotictakenFlat"] = 0,

Check warning on line 327 in spec/TestBuilds/1.2/warpath_channel.lua

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Necrotictaken)
["NumberOfDamagingHits"] = 2.5954,
["NumberOfMitigatedDamagingHits"] = 2.5954,
["OffensiveWarcryEffect"] = 1,
Expand Down Expand Up @@ -358,7 +358,7 @@
["PhysicalTakenReflect"] = 1,
["PhysicalTotalHitPool"] = 3400,
["PhysicalTotalPool"] = 3400,
["PhysicaltakenFlat"] = 0,

Check warning on line 361 in spec/TestBuilds/1.2/warpath_channel.lua

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Physicaltaken)
["PoisonAegis"] = 0,
["PoisonAfterReductionTakenHitMulti"] = 1,
["PoisonAttackTakenHitMult"] = 1,
Expand Down Expand Up @@ -389,7 +389,7 @@
["PoisonTakenReflect"] = 1,
["PoisonTotalHitPool"] = 3400,
["PoisonTotalPool"] = 3400,
["PoisontakenFlat"] = 0,

Check warning on line 392 in spec/TestBuilds/1.2/warpath_channel.lua

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Poisontaken)
["PreEffectiveCritChance"] = 14.4,
["ProjectileBlockChance"] = 0,
["ProjectileEvadeChance"] = 0,
Expand Down Expand Up @@ -517,7 +517,7 @@
["VoidTakenReflect"] = 1,
["VoidTotalHitPool"] = 3400,
["VoidTotalPool"] = 3400,
["VoidtakenFlat"] = 0,

Check warning on line 520 in spec/TestBuilds/1.2/warpath_channel.lua

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Voidtaken)
["Ward"] = 0,
["WardDecayThreshold"] = 0,
["WardPerSecond"] = 0,
Expand Down
46 changes: 31 additions & 15 deletions spec/TestBuilds/1.2/warpath_channel.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,14 @@
<PlayerStat stat="VoidResist" value="75"></PlayerStat>
<PlayerStat stat="VoidResistOverCap" value="1"></PlayerStat>
<PlayerStat stat="EffectiveMovementSpeedMod" value="1.56"></PlayerStat>
<PlayerStat stat="FullDPS" value="8730.4420627375"></PlayerStat>
<PlayerStat stat="FullDPS" value="8795.7605396747"></PlayerStat>
<FullDPSSkill skillPart="" source="" stat="Smite" value="7846.0256559886"></FullDPSSkill>
<FullDPSSkill skillPart="" source="Smite" stat="Ignite" value="826.61037795706"></FullDPSSkill>
<FullDPSSkill skillPart="" source="Smite" stat="Electrify" value="57.806028791839"></FullDPSSkill>
<FullDPSSkill skillPart="" source="Smite" stat="Electrify" value="58.125399116656"></FullDPSSkill>
<FullDPSSkill skillPart="" source="Smite" stat="Axe Throw" value="43.881438095962"></FullDPSSkill>
<FullDPSSkill skillPart="" source="AxeThrow" stat="Ignite" value="18.893951496161"></FullDPSSkill>
<FullDPSSkill skillPart="" source="AxeThrow" stat="Electrify" value="1.3285271645726"></FullDPSSkill>
<FullDPSSkill skillPart="" source="AxeThrow" stat="Axe Throw" value="0.89518985559494"></FullDPSSkill>
</Build>
<Calcs>
<Input name="misc_buffMode" string="EFFECTIVE"></Input>
Expand All @@ -74,7 +78,7 @@
<Section collapsed="false" id="Speed" subsection="AttackCastRate"></Section>
<Section collapsed="false" id="Crit" subsection="Crits"></Section>
<Section collapsed="false" id="SkillTypeStats" subsection="SkilltypespecificStats"></Section>
<Section collapsed="false" id="LeechGain" subsection="LeechGainonHit"></Section>

Check warning on line 81 in spec/TestBuilds/1.2/warpath_channel.xml

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Gainon)
<Section collapsed="false" id="MiscEffects" subsection="OtherEffects"></Section>
<Section collapsed="false" id="Attributes" subsection="Attributes"></Section>
<Section collapsed="false" id="Life" subsection="Health"></Section>
Expand All @@ -90,7 +94,7 @@
<Section collapsed="false" id="DamageTaken" subsection="DamagingHits"></Section>
<Section collapsed="false" id="DamageTaken" subsection="EffectiveHealthPool"></Section>
<Section collapsed="false" id="DamageTaken" subsection="MaximumHitTaken"></Section>
<Section collapsed="false" id="DamageTaken" subsection="DotsandDegens"></Section>

Check warning on line 97 in spec/TestBuilds/1.2/warpath_channel.xml

View workflow job for this annotation

GitHub Actions / spellcheck 

Unknown word (Dotsand)
</Calcs>
<Config>
<Input name="bandit" string="None"></Input>
Expand Down Expand Up @@ -842,19 +846,31 @@
<Skill enabled="true" includeInFullDPS="true" index="8" label="Electrify (from Smite)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Smite"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="9" label="Ignite (from Smite)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Ignite" source="SkillId:Smite"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="10" label="Shock (from Smite)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Smite"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="11" label="Shred Armor (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="12" label="Bleed (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="13" label="Blind (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="14" label="Electrify (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="15" label="Shock (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="16" label="Shred Armor (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="17" label="Bleed (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="18" label="Blind (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="19" label="Electrify (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="20" label="Frailty (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Frailty" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="21" label="Ignite (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Ignite" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="22" label="Shock (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="23" label="Slow (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Slow" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="11" label="Axe Throw (from Smite)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="AxeThrow" source="SkillId:Smite"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="12" label="Shred Armor (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="13" label="Bleed (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="14" label="Blind (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="15" label="Electrify (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="16" label="Shock (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="17" label="Axe Throw (from Warpath)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="AxeThrow" source="SkillId:Warpath"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="18" label="Shred Armor (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="19" label="Bleed (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="20" label="Blind (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="21" label="Electrify (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="22" label="Frailty (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Frailty" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="23" label="Ignite (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Ignite" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="24" label="Shock (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="25" label="Slow (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Slow" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="false" index="26" label="Axe Throw (from Javelin)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="AxeThrow" source="SkillId:Javelin"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="27" label="Shred Armor (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_ArmourShred" source="SkillId:AxeThrow"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="28" label="Blind (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Blind" source="SkillId:AxeThrow"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="29" label="Electrify (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Electrify" source="SkillId:AxeThrow"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="30" label="Ignite (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Ignite" source="SkillId:AxeThrow"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="31" label="Shock (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Shock" source="SkillId:AxeThrow"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="32" label="Axe Throw (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="AxeThrow" source="SkillId:AxeThrow"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="34" label="Bleed (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Bleed" source="SkillId:AxeThrow"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="43" label="Frailty (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Frailty" source="SkillId:AxeThrow"></Skill>
<Skill enabled="true" includeInFullDPS="true" index="46" label="Slow (from Axe Throw)" mainActiveSkill="1" mainActiveSkillCalcs="nil" skillId="Ailment_Slow" source="SkillId:AxeThrow"></Skill>
</SkillSet>
</Skills>
<Tree activeSpec="1">
Expand Down
Loading
Loading