Skip to content

Conversation

@jesse-dugan
Copy link
Collaborator

Modified functions, docs etc. to ensure that we remain consistent with infrasys spelling of time series as two words.

Change Summary

  • Any time we used timeseries, I switched it to time_series.
  • TimeSeries already implies two words so that stayed the same.
  • Also, I found an import error in src\gdm\cli\reducer.py so I fixed that as well. We don't have tests for CLI I guess?

Related issue number

Checklist

  • The pull request title is a good summary of the changes.
  • Tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including "please review" to assign reviewers

modified functions, docs etc. to ensure that we remain consistent with infrasys spelling of time series as two words. Any time we used timeseries, I switched it to time_series. TimeSeries already implies two words so that stayed the same. Also found an import error in src\gdm\cli\reducer.py so I fixed that as well. We don't have tests for CLI I guess?
@jesse-dugan jesse-dugan self-assigned this Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 98.47328% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.94%. Comparing base (bfea828) to head (a152457).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/gdm/distribution/sys_functools.py 93.54% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         111      111           
  Lines        3598     3598           
=======================================
  Hits         3452     3452           
  Misses        146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jesse-dugan
Copy link
Collaborator Author

jesse-dugan commented Oct 20, 2025

please review @AadilLatif

@AadilLatif
Copy link
Collaborator

please review @AadilLatif

This looks great. I will make it part of the next release. I want to communicate upcoming changes and take some time, as it will break all downstream tools,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants