update supplemental accessors #1574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
==========================================
- Coverage 83.76% 83.60% -0.16%
==========================================
Files 200 200
Lines 10186 10205 +19
==========================================
Hits 8532 8532
- Misses 1654 1673 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
m-bossart
reviewed
Nov 7, 2025
| (for each of the 3 branches) accounting for turns ratios. | ||
| For each winding, the series admittance is calculated following the same pattern as the susceptance calculation: | ||
| Yi = 1/(turns_ratio_i * (Ri + jXi)). | ||
| The phase shift angles affect the admittance matrix construction but not the series impedance magnitudes directly. |
Contributor
There was a problem hiding this comment.
"The phase shift angles affect the admittance matrix construction but not the series admittance values directly."
m-bossart
reviewed
Nov 7, 2025
| For a phase-shifting transformer, the series admittance is calculated as the inverse of the | ||
| complex impedance modified by the tap ratio, following the same pattern as the susceptance calculation: | ||
| Y = 1/(tap * (R + jX)). | ||
| The phase angle α affects the admittance matrix construction but not the series impedance magnitude directly. |
Contributor
There was a problem hiding this comment.
"The phase angle α affects the admittance matrix construction but not the series admittance value directly."
m-bossart
approved these changes
Nov 7, 2025
Contributor
|
Two suggestions on the wording of the docstrings, otherwise looks good |
Member
Author
|
@m-bossart I'll keep it open until we are sure of the equations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This are used in PNM's NREL-Sienna/PowerNetworkMatrices.jl#203