Fix broken links #1199
Open
Fix broken links #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curator links renamed domino to external aerodynamics, fixing.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
Updated two broken documentation links in the DoMINO README that reference the physicsnemo-curator repository. The curator repository restructured its examples, moving content from examples/external_aerodynamics/domino/ to examples/external_aerodynamics/.
Changes:
- Updated download instructions link to point to correct path with anchor
- Updated data curation guide link to point to external_aerodynamics directory
Note: Similar broken links exist in examples/cfd/external_aerodynamics/transolver/README.md that should also be addressed.
Confidence Score: 5/5
- This PR is safe to merge with no risk
- Documentation-only change fixing broken links with straightforward path updates. No code logic or functionality affected.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| examples/cfd/external_aerodynamics/domino/README.md | 5/5 | Updated two broken physicsnemo-curator links from /domino/ path to /external_aerodynamics/ path |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant PR as Pull Request #1199
participant Repo as physicsnemo Repository
participant Doc as DoMINO README
participant Curator as physicsnemo-curator Repo
Dev->>PR: Create PR to fix broken links
PR->>Doc: Update line 88: curator link path
PR->>Doc: Update line 94: curator link path
Note over Doc: /domino/README.md → /external_aerodynamics
Doc->>Curator: Links now point to correct paths
Curator-->>Doc: Returns valid documentation
PR->>Repo: Ready to merge
Note over Repo: Documentation links fixed
1 file reviewed, 1 comment
|
|
||
| Download the DrivAer ML dataset using the | ||
| [provided instructions in PhysicsNeMo-Curator](https://github.com/NVIDIA/physicsnemo-curator/blob/main/examples/external_aerodynamics/domino/README.md#download-drivaerml-dataset). | ||
| [provided instructions in PhysicsNeMo-Curator](https://github.com/NVIDIA/physicsnemo-curator/tree/main/examples/external_aerodynamics#download-drivaerml-dataset). |
Contributor
There was a problem hiding this comment.
style: Check examples/cfd/external_aerodynamics/transolver/README.md:40-41 - has similar broken links with old /domino/ path that need fixing
Collaborator
Author
|
@RishikeshRanade could you take a look at this? Should be very quick to review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curator links renamed domino to external aerodynamics, fixing.
PhysicsNeMo Pull Request
Closes #1197
Description
Checklist
Dependencies