Skip to content

Refactor GroupNorm and log unmatched state_dict keys #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor GroupNorm and log unmatched state_dict keys #989

wants to merge 3 commits into from

Conversation

juliusberner
Copy link
Contributor

@juliusberner juliusberner commented Jun 24, 2025 •
edited
Loading

PhysicsNeMo Pull Request

Description

  • Refactor GroupNorm and add get_group_norm to keep the state_dict consistent with previous versions.
  • Log missing and unexpected keys when loading checkpoints.
  • Add persistent=False for deterministic, non-learnable positional embeddings.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Refactor GroupNorm and log unmatched state_dict keys
b870c49 
Signed-off-by: Julius Berner <jberner@nvidia.com>
@CharlelieLrt CharlelieLrt self-requested a review June 24, 2025 21:05
@CharlelieLrt CharlelieLrt added bug Something isn't working 3 - Ready for Review Ready for review by team labels Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlelieLrt CharlelieLrt Awaiting requested review from CharlelieLrt

At least 1 approving review is required to merge this pull request.

Assignees

@juliusberner juliusberner

Labels
3 - Ready for Review Ready for review by team bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusberner @CharlelieLrt