libutil: Less unnecessary copying in LRUCache
(backport #13193)
#13672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's some low hanging fruit in terms of code simplification and getting rid
of unnecessary copying (see the second commit). Also moving the cache entry to the back of the
lru
list can bemade much cheaper by just using splice method, which just reassigns some pointers in the linked list (having pointer stability is the main purpose of
std::list
after all).Context
Some unified caching primitives are useful to reuse in other places (e.g. #13137 (comment))
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #13193 done by [Mergify](https://mergify.com).