-
-
Notifications
You must be signed in to change notification settings - Fork 545
[19.0][MIG] mrp_bom_attribute_match: Migration to 19.0. #1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hieulucky111
wants to merge
48
commits into
OCA:19.0
Choose a base branch
from
komit-consulting:19.0-mig-mrp_bom_attribute_match
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[19.0][MIG] mrp_bom_attribute_match: Migration to 19.0. #1632
hieulucky111
wants to merge
48
commits into
OCA:19.0
from
komit-consulting:19.0-mig-mrp_bom_attribute_match
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 83.3% (15 of 18 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_bom_attribute_match/hr/
Currently translated at 100.0% (16 of 16 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_bom_attribute_match/it/
… of a component_template_id.
Notes:
* `_get_product2bom` renamed to `_bom_find`
* Test case `test_manufacturing_order_2`:
* No longer check for "Add some materials to consume before marking this MO as to do.",
as it's already supported in core since odoo/odoo@bf5e1debf
The check expects a single record, so it should be processed accordingly.
These methods shouldn't be exposed to xmlrpc.
The same result can be achieved with a computed field. Moreover, we have one already in odoo core. Originally it was a related field, but we can change it to a computed and add our extra logic there.
Instead of updates triggered by onchanges or writes, use constraints to execute all checks, and a computed field for `match_on_attribute_ids`
There isn't any reson to depend on it.
Currently translated at 100.0% (19 of 19 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/it/
Currently translated at 100.0% (19 of 19 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/
Currently translated at 100.0% (17 of 17 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/it/
Currently translated at 100.0% (17 of 17 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/it/
Currently translated at 100.0% (17 of 17 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/it/
Currently translated at 100.0% (17 of 17 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/es/
… have cyclic references in bom.
Currently translated at 100.0% (17 of 17 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/it/
Currently translated at 100.0% (17 of 17 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-15.0/manufacture-15.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_attribute_match/
Currently translated at 100.0% (17 of 17 strings) Translation: manufacture-18.0/manufacture-18.0-mrp_bom_attribute_match Translate-URL: https://translation.odoo-community.org/projects/manufacture-18-0/manufacture-18-0-mrp_bom_attribute_match/tr/
3e00516 to
ded0850
Compare
cd5e797 to
ded0850
Compare
ded0850 to
aaf74ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.