-
Notifications
You must be signed in to change notification settings - Fork 45
Add Export Functionality #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pattern so far has been to make actions into query strings, e.g. ?export=true
this is to prevent accidentally exporting things when you call
node/US_CRYPTO_EXPORT/foo
i'll fix this in the next few days
other than that it's good work, thank you
TODO: @northdpole , add documentation on how to setup a gspread oauth token so that the backend can generate the spreadsheet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can easily be abused by bots, can you please
- make this feature optional (hide it behind an environment variable when building the frontend ?
- add a captcha challenge for clicking the button
yarn-error.log | ||
coverage/ | ||
|
||
## Database Cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New keyword noted.great
e2e: | ||
yarn build | ||
[ -d "./venv" ] && . ./venv/bin/activate | ||
export FLASK_APP=$(CURDIR)/cre.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better
|
||
Common Requirements Enumeration Application | ||
=============================== | ||
# Common Requirements Enumeration Application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloned
|
||
Install dependencies | ||
<pre> make install </pre> | ||
# Install the dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes true logic is correct
- [x] > refer use case (search by cre) | ||
- [x] > search by standard | ||
- [x] add the ability for a mapping document to have multiple yamls in it | ||
- [x] add db integration of tags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to delete it also works perfecty
@@ -0,0 +1,5 @@ | |||
a.export-button { | |||
font-size: 1.2rem; | |||
margin-left: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great view of styling
import { applyFilters } from '../../hooks/applyFilters'; | ||
import { Document } from '../../types'; | ||
import { groupLinksByType } from '../../utils'; | ||
import { applyFilters, filterContext } from '../../hooks/applyFilters'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to remove
<h4 className="cre-page__heading">{display.name}</h4> | ||
<h4 className="cre-page__heading"> | ||
{display.name} | ||
<ExportButton fetchURL={FETCH_URL} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New version of same thing better
} | ||
{display.tags? | ||
<div className="cre-page__tags">Tags:{display.tags.map((tag) => ( <b>{tag} </b>))}</div>:""} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to delete
import { useParams } from 'react-router-dom'; | ||
import axios from 'axios'; | ||
|
||
import { useEnvironment } from '../../hooks'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to remove this lib
Fixes #161
https://www.loom.com/share/67d67449e98649dc9fffe0f180d5dee8