Rule plugins simple2 #231
Open
Rule plugins simple2 #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesmj
reviewed
Jan 15, 2024
| super().__init__() | ||
| self.plugin_path = __file__ | ||
|
|
||
| def connected_elements(self, element): |
There was a problem hiding this comment.
Could this be a function of an Element rather than in the rule definition? Seems it could be reused for other things, and taking a couple of extra parameters perhaps to be generically useful.
There was a problem hiding this comment.
That would be better. I want to make changes by this feature in the core code as minimal as possible. Maybe create a separate PR for the Element upgrade ? Which parameters do you propose ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #19 A PR for an additional plugin system to cover rule plugins. As an example it contains a semi complex sql injection plugin.