Skip to content

[php] Fixed typing of offsetGet/offsetSet/offsetUnset #21583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

[php] Fixed typing of offsetGet/offsetSet/offsetUnset #21583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions modules/openapi-generator/src/main/resources/php/model_generic.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,24 +476,24 @@ class {{classname}} {{#parentSchema}}extends {{{parent}}}{{/parentSchema}}{{^par
/**
* Returns true if offset exists. False otherwise.
*
* @param integer $offset Offset
* @param integer|string $offset Offset
*
* @return boolean
*/
public function offsetExists($offset): bool
public function offsetExists(mixed $offset): bool
{
return isset($this->container[$offset]);
}

/**
* Gets offset.
*
* @param integer $offset Offset
* @param integer|string $offset Offset
*
* @return mixed|null
*/
#[\ReturnTypeWillChange]
public function offsetGet($offset)
public function offsetGet(mixed $offset)
{
return $this->container[$offset] ?? null;
}
Expand All @@ -518,11 +518,11 @@ class {{classname}} {{#parentSchema}}extends {{{parent}}}{{/parentSchema}}{{^par
/**
* Unsets offset.
*
* @param integer $offset Offset
* @param integer|string $offset Offset
*
* @return void
*/
public function offsetUnset($offset): void
public function offsetUnset(mixed $offset): void
{
unset($this->container[$offset]);
}
Expand Down
Loading