Rate limiting cache #2627
Open
Rate limiting cache #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key Features of the Implementation: 1. **Proper Location**: Caching is implemented at the data layer (`MappedRateLimitingProvider`) rather than the business logic layer 2. **Hourly Cache Invalidation**: Uses `YYYY-MM-DD-HH24` format in cache key for automatic hourly invalidation 3. **Configurable TTL**: Defaults to 1 hour (3600 seconds), can be customized via properties 4. **Documentation**: Properly documented in sample.props.template with clear explanation 5. **Consistent Pattern**: Follows the exact same caching pattern as other cached functions in the codebase 6. **Per-Consumer Caching**: Each consumer gets its own cache to prevent cross-consumer interference
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.