Skip to content

Remove redundant vcpkg steps #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elsid
Copy link
Collaborator

@elsid elsid commented Apr 5, 2025

VCPKG_REPOSITORY points to the upstream, no need to duplicate a remote for it.

@AnyOldName3
Copy link
Member

When I first looked at this I was confused as I couldn't see where vcpkg was coming from if we weren't adding any remote at all, but it's one of the things that's preinstalled on GitHub's runners. It might make that a little clearer if we use the documented VCPKG_INSTALLATION_ROOT environment variable rather than hardcoding C:\vcpkg, which is undocumented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants