Test: Mtl manager fixture #1219
Open
+82
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkuta
requested review from
Sakoram,
DawidWesierski4 and
Falron98
as code owners
|
Please add sensible git PR description |
staszczuk
requested changes
Aug 6, 2025
andremiszcz
requested changes
Aug 18, 2025
| for host in hosts.values(): | ||
| mgr = MtlManager(host) | ||
| mgr.start() | ||
| managers[host.name] = mgr |
There was a problem hiding this comment.
I think we should raise error here if start returned False
| connection = self.host.connection | ||
| try: | ||
| logger.info("Stopping MtlManager using sudo pkill MtlManager...") | ||
| connection.execute_command("sudo pkill MtlManager") |
There was a problem hiding this comment.
It would be better to use self.mtl_manager_process.stop() method or wait / kill () methods than this.
Also it would be nice to verify logs for errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class adds a class to manage the lifecycle of the MtlManager process on a remote host, as well as a connected fixture, that turns the MtlManager on at the beginning of the test and off at the end of it.