Add dual host ffmpeg tests #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change test cases names; Adjust logging;
Falron98
force-pushed
the
ffmpeg_dual_tests
branch
from
fb99d2d to
a9dda32
Compare
Falron98
force-pushed
the
ffmpeg_dual_tests
branch
from
a9dda32 to
9bac7a5
Compare
MateuszGrabuszynski
approved these changes
Aug 18, 2025
1 task
Falron98
force-pushed
the
ffmpeg_dual_tests
branch
from
8f9835c to
0693814
Compare
staszczuk
reviewed
Aug 21, 2025
staszczuk
reviewed
Aug 21, 2025
andremiszcz
requested changes
Aug 21, 2025
There was a problem hiding this comment.
Please get rid of unnecessary try except lines, if you need try except, try to catch exact condition (Exception is too wide and causes catching unexpected problems which can hide another issues). Please short some lines of checking stdout maybe a function common for all stdout checks?
andremiszcz
requested changes
Aug 22, 2025
andremiszcz
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.