Skip to content

Conversation

NeonDaniel
Copy link
Member

Add file extension mapping for react GUI
Add core messagebus event forwarding to support current react GUI implementation https://github.com/alexisdiaz008/react-mycroft-gui/blob/master/src/components/mycroft_message_bus_elements/mycroft_message_bus.jsx

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@e8d9ca6). Click here to learn what that means.

❗ Current head daeb42b differs from pull request most recent head 29e25ab. Consider uploading reports for the commit 29e25ab to get more accurate results

Files Patch % Lines
ovos_gui/bus.py 0.00% 3 Missing ⚠️
ovos_gui/page.py 60.00% 2 Missing ⚠️
ovos_gui/namespace.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #26   +/-   ##
======================================
  Coverage       ?   52.73%           
======================================
  Files          ?       11           
  Lines          ?     1022           
  Branches       ?        0           
======================================
  Hits           ?      539           
  Misses         ?      483           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonDaniel
Copy link
Member Author

@alexisdiaz008 I think this is a good starting point for react support on the core side

"""
if framework in ("qt5", "qt6"):
return "qml"
if framework == "react":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there different versions or flavors we should support here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe vue?

@JarbasAl JarbasAl mentioned this pull request Sep 29, 2023
36 tasks
@NeonDaniel NeonDaniel force-pushed the FEAT_ReactGuiSupport branch from e39575c to 7d6c523 Compare October 5, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants