Update logger_prefs.sql #227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have only OR in a where-clause, the (dummy) first clause should not be "1=1" (always TRUE, like used when the where-clause is composed of ANDs), but "1=0" to have an always FALSE to start out with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have only OR in a where-clause, the (dummy) first clause should not be "1=1" (always TRUE, like used when the where-clause is composed of ANDs), but "1=0" to have an always FALSE to start out with.
Currently, ALL records of logger_prefs are updated. With this bug, to much work is performed, but the result is fortunately the same (supposing there are no active triggers on that table).