[WIP] GNMI module #2435
Draft
[WIP] GNMI module #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobianas
force-pushed
the
gnmi
branch
9 times, most recently
from
5122ebd to
53fde6b
Compare
GnmiSouthboundProvider expected to be provided a path to initial models from json configuration. Since we are no longer relying on json configuration, we need to provide them manually.
ihrasko
reviewed
Oct 31, 2025
Tobianas
force-pushed
the
gnmi
branch
2 times, most recently
from
1762ddd to
9801f2d
Compare
ihrasko
reviewed
Nov 4, 2025
Collaborator
ihrasko
left a comment
ihrasko
left a comment
There was a problem hiding this comment.
Disable maven-dependency plugin and make cleanups.
Tobianas
force-pushed
the
gnmi
branch
3 times, most recently
from
d307fa0 to
1e5cc28
Compare
We do not need this since GnmiSouthboundModule is now component
The point of this rework is to not rely on other lighty modules to run gnmi. Let's rather use what is available from opendaylight instead.
Tobianas
force-pushed
the
gnmi
branch
2 times, most recently
from
33839dc to
2d5fa35
Compare
ihrasko
requested changes
Nov 10, 2025
| @@ -0,0 +1,66 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Collaborator
There was a problem hiding this comment.
copyright on new files, please
| @@ -0,0 +1,3 @@ | |||
| -noextraheaders: true | |||
Collaborator
There was a problem hiding this comment.
what's the purpose of this file?
features/features-gnmi/pom.xml
Outdated
|
|
||
|
|
||
| <properties> | ||
| <maven.compiler.source>21</maven.compiler.source> |
Collaborator
There was a problem hiding this comment.
Java 21 source/target should be inherited from odparent
| @@ -0,0 +1,103 @@ | |||
| /* | |||
Collaborator
There was a problem hiding this comment.
where are these files from? what's their purpose?
| <dependency> | ||
| <groupId>org.opendaylight.aaa</groupId> | ||
| <artifactId>aaa-encrypt-service</artifactId> | ||
| <groupId>org.bouncycastle</groupId> |
Collaborator
There was a problem hiding this comment.
I would expect to depend on odlparent/aaa instead
| this.gnmiExecutorService, this.appModuleConfig.getGnmiConfiguration(), encryptionService, | ||
| this.customReactor); | ||
| startAndWaitLightyModule(this.gnmiSouthboundModule); | ||
| gnmiSouthboundModule.init(); |
Collaborator
There was a problem hiding this comment.
the next logical step would be to translate this module to OSGI and use @reference gnmiSouthboundModule
| final AAAEncryptionService encryptionService, | ||
| @Nullable final GnmiConfiguration configuration, | ||
| @Nullable final CrossSourceStatementReactor customReactor) { | ||
| @Activate |
| @Activate | ||
| public GnmiSouthboundModule(@Reference DataBroker dataBroker, @Reference RpcProviderService rpcProviderService, | ||
| @Reference DOMMountPointService domMountPointService, @Reference AAAEncryptionService encryptionService) { | ||
| this.dataBroker = Objects.requireNonNull(dataBroker); |
Collaborator
There was a problem hiding this comment.
requireNonNull() with static import
| protected boolean initProcedure() { | ||
| LOG.info("Starting lighty gNMI Southbound Module"); | ||
| final List<YangLoaderService> initialLoaders = prepareByPathLoaders(); | ||
| @Activate |
Collaborator
There was a problem hiding this comment.
please check docs how to have multiple @activate methods
| .YangModuleInfoImpl.getInstance() | ||
| ); | ||
|
|
||
| public static final Set<YangModuleInfo> OPENCONFIG_YANG_MODELS = Set.of( |
Collaborator
There was a problem hiding this comment.
optional: in follow-up patches we can use dependency on mdsal/ietf features
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.