-
Notifications
You must be signed in to change notification settings - Fork 80
Vanadium integration #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Vanadium integration #2436
Conversation
Summary of ChangesHello @PeterSuna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant integration by upgrading the project's dependencies to align with the OpenDaylight Vanadium release. It involves bumping numerous component versions and standardizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the versions of several OpenDaylight dependencies in the dependency-versions/pom.xml file and replaces some org.opendaylight.mdsal.binding.model.iana dependencies with org.opendaylight.ietf.model in various pom.xml files. Additionally, it removes the pekko-segmented-journal dependencies and persistence journal configurations. The dependency version updates seem reasonable, but the removal of the persistence journal configurations warrants closer inspection to ensure no data loss or functional regressions occur.
| <version>0.24.0-SNAPSHOT</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for bgpcep-artifacts is using a -SNAPSHOT version. While this might be acceptable for development, it's generally not recommended for stable releases. Consider using a released version if available.
If a released version is not available, confirm that the snapshot version is intended for this integration.
e7d0f97 to
c6a986c
Compare
Adopt: - odlparent-14.1.6 - infrautils-7.1.9 - yangtools-14.0.20 - mdsal-15.0.2 - controller-12.0.2 - aaa-0.22.2 - netconf-10.0.1 - bgpcep-0.24.0-SNAPSHOT JIRA: LIGHTY-391 Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
MDSAL-886 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
CONTROLLER-2152 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
CONTROLLER-2149 MDSAL-817 MDSAL-889 Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
CONTROLLER-2151 Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
CONTROLLER-2130 CONTROLLER-2175 Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
CONTROLLER-2167 Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
default is HTTP_2 https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html#version() Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
NETCONF-1502 Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
JIRA: LIGHTY-391