WIP: Make number of Netty thread configurable #2448
Conversation
We have hard-coded number of Netty threads to be 1 which is too limiting. Fix this. Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Summary of ChangesHello @ihrasko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates the process of making the number of Netty worker threads configurable, moving away from a restrictive hardcoded value. The change aims to improve the scalability and performance of the RESTCONF Netty server by allowing dynamic adjustment of thread resources, though full configurability is marked for future implementation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to make the number of Netty threads configurable by replacing SimpleNettyEndpoint with OSGiNettyEndpoint. However, the current changes are incomplete and introduce a compilation error because the bootstrapFactory variable is used without being defined. My review provides a fix to make the code compilable while respecting the intent to use Netty's default thread count, and also points out a minor issue in a comment.
| * 2. create lighty.io config | ||
| * 2. hardcode 0 which is ODL netconf default allowing to use Netty default | ||
| */ | ||
| final var pros = OSGiNettyEndpoint.props(bootstrapFactory, configuration); |
There was a problem hiding this comment.
This line will not compile because the bootstrapFactory variable is not defined. You've removed the BootstrapFactory instantiation, but it's still required by OSGiNettyEndpoint.props().
To fix this, you need to create a BootstrapFactory instance before this line. Based on the FIXME comment, you likely want to use 0 threads to use Netty's default. You could add the following line before this one:
final var bootstrapFactory = new org.opendaylight.netconf.transport.tcp.BootstrapFactory("lighty-restconf-nb-worker", 0);Note that you'll need to use the fully qualified name or re-add the import for BootstrapFactory.
| * | ||
| * 1. use new RestconfBootstrapFactory(bootstrapFactoryConfig) | ||
| * 2. create lighty.io config | ||
| * 2. hardcode 0 which is ODL netconf default allowing to use Netty default |
There was a problem hiding this comment.
There's a small typo in the numbering of this list; the second item 2. should probably be 3..
| * 2. hardcode 0 which is ODL netconf default allowing to use Netty default | |
| * 3. hardcode 0 which is ODL netconf default allowing to use Netty default |
1 participant
We have hard-coded number of Netty threads to be 1 which is too limiting. Fix this.