Add the missing properties for setup #147
Conversation
WalkthroughThe pull request introduces a comprehensive set of configuration properties in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
src/main/resources/application.properties (4)
191-193: Improve configuration clarity with proper documentationThe
cz-duration=40property lacks:
- Unit specification (seconds, minutes, hours?)
- Purpose documentation
- Validation constraints
Add comments to clarify the purpose and unit:
##CTI data sync schedular +# Duration in minutes for CTI data synchronization +# Allowed range: 30-120 minutes cz-duration=40
197-202: Document configuration constraints and unitsThe following properties need better documentation:
everwellCalendarDuration=15- Missing unit specificationlonicPageSize=10- Missing validation constraintsAdd documentation for clarity:
##duration for everwell calender +# Duration in days for Everwell calendar data retention +# Recommended range: 7-30 days everwellCalendarDuration=15 ##lonic variables +# Number of items per page for Lonic data pagination +# Recommended range: 10-50 items lonicPageSize=10
203-205: Document retry strategyThe
callRetryConfiguration=3property would benefit from documentation about:
- Retry intervals
- Backoff strategy
- Timeout settings
Add comprehensive retry documentation:
#call retry count +# Maximum number of retry attempts for failed calls +# Note: Uses exponential backoff with 1s initial delay +# Related properties: +# - call.retry.initial.delay.ms=1000 +# - call.retry.max.delay.ms=5000 callRetryConfiguration=3
211-214: Review scheduler timing conflictsMultiple schedulers are configured to run around midnight:
- CTI data check:
0 10 00 * * *(12:10 AM)- NHM dashboard:
0 1 * * * ? *(12:01 AM)This clustering of jobs around midnight could:
- Cause resource contention
- Impact system performance
- Lead to potential deadlocks or timeouts
Consider:
- Distributing the jobs across different time windows
- Implementing a queue-based approach for job execution
- Adding timeout configurations for each scheduler
Also applies to: 228-230
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/resources/application.properties(1 hunks)
🔇 Additional comments (2)
src/main/resources/application.properties (2)
188-189: Review the polling frequency for NHM agent dataThe current cron schedule (
0 */2 * ? * *) polls every 2 minutes, which might be:
- Too frequent for the system's needs
- Resource-intensive over time
- Potentially causing unnecessary load on the target system
Could you confirm if this polling frequency is actually required? Consider increasing the interval if real-time data is not critical.
217-219: Optimize high-frequency scheduler configurationsThe following schedulers have very frequent execution intervals:
- Avni registration: Every 1 minute (
0 0/1 * * * ? *)- Everwell data sync: Every 5 minutes (
0 0/5 * * * ? *)Please confirm if such high-frequency scheduling is necessary. Consider:
- Implementing event-driven processing instead of frequent polling
- Using message queues for real-time data synchronization
- Increasing intervals if real-time processing is not critical
Run this script to analyze the impact of these schedulers:
Also applies to: 225-227
| avniRegistrationLimit=7 | ||
|
|
||
| #--------------------------NHM Agent Real Time Data---------------------------- | ||
| nhm.agent.real.time.data.url= http://175.101.1.83/apps/utility/alive_api.php |
There was a problem hiding this comment.
Replace hardcoded IP address with configurable hostname
Using a hardcoded IP address (175.101.1.83) is not recommended as it:
- Makes environment switching difficult
- Creates maintenance overhead
- Could pose security risks if exposed in version control
Consider using a placeholder and moving the actual value to environment-specific configuration:
-nhm.agent.real.time.data.url= http://175.101.1.83/apps/utility/alive_api.php
+nhm.agent.real.time.data.url=${NHM_AGENT_HOST}/apps/utility/alive_api.php📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| nhm.agent.real.time.data.url= http://175.101.1.83/apps/utility/alive_api.php | |
| nhm.agent.real.time.data.url=${NHM_AGENT_HOST}/apps/utility/alive_api.php |
There was a problem hiding this comment.
@drtechie this link needs to be reviewed
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
📋 Description
JIRA ID:
While setting up the COMMON-API locally, some properties required to start the application were missing. The missing properties have been added to the application.properties file.
✅ Type of Change
Summary by CodeRabbit