-
Notifications
You must be signed in to change notification settings - Fork 46
Fix column name mismatch in StockAlertData class and v_emailstockalert table #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates the database mapping for the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/iemr/common/data/email/StockAlertData.java (1)
80-82
: Column name updated correctly, but field name should be aligned with column semantics.The column mapping has been correctly updated from "QuantityinhandPercent" to "QuantityConsumedPercent" to match the database view. This fixes the reported error in the PR objectives.
However, there's a semantic inconsistency between the Java field name
quantityinhandPercent
(suggesting "quantity on hand") and the column name it now maps toQuantityConsumedPercent
(indicating "quantity consumed"). These represent opposite concepts that could confuse developers.Consider renaming the field to match the column semantics:
@Column(name = "QuantityConsumedPercent") @Expose - private Double quantityinhandPercent; + private Double quantityConsumedPercent;Additionally, the current field name doesn't follow proper Java camelCase convention (should be
quantityInHandPercent
if keeping the current name).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/iemr/common/data/email/StockAlertData.java
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: style-check / checkstyle
- GitHub Check: Package-test
- GitHub Check: Analyze (java)
- GitHub Check: Build
📋 Description
JIRA ID:
The column name in the StockAlertData class does not match the corresponding column in the v_emailstockalert table, causing an error during execution. This PR resolves the issue by aligning the column names correctly.
✅ Type of Change
Summary by CodeRabbit